conversions: fix FromPyObject impl for uuid::Uuid for big-endian #5161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
approved these changes
May 23, 2025
There was a problem hiding this comment.
The reason to_le was originally used here is because pydantic-core did the same (see pydantic/pydantic-core#1372), and it was thought to be necessary. However, that change was later reverted in pydantic/pydantic-core#1393, as it turned out to be unnecessary due to a fix in PyO3 v0.22.1.
So this usage should definitely be removed here as well. 👍
|
Can you please add a changelog entry in the |
The "to_le()" conversion on the u128 seems to be just wrong.
|
Done, thank you for taking a look! |
davidhewitt
pushed a commit
that referenced
this pull request
Jun 11, 2025
The "to_le()" conversion on the u128 seems to be just wrong.
davidhewitt
pushed a commit
that referenced
this pull request
Jun 12, 2025
The "to_le()" conversion on the u128 seems to be just wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "to_le()" conversion on the u128 seems to be just wrong. See #5160 for a more thorough investigation that led me to this simple "delete 8 characters to fix the problem" fix :)
Note that it looks like this implementation has always been wrong since it was originally added ... I'll likely end up backporting this change to older PyO3 versions that we still need to support in Fedora Linux and EPEL.
Fixes #5160