Skip to content

PyGetSetDef: Remove Eq and PartialEq #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

PyGetSetDef: Remove Eq and PartialEq #5196

merged 1 commit into from
Jun 18, 2025

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Jun 17, 2025

Clippy notes that "function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique"

@Tpt Tpt force-pushed the pygetsetdef-eq branch from a3a3f7c to c602c1c Compare June 17, 2025 13:04
davidhewitt
davidhewitt approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have generally been removing traits from these structs so seems good to me, thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Jun 18, 2025
Merged via the queue into PyO3:main with commit a9e3f81 Jun 18, 2025
44 of 45 checks passed
@Tpt Tpt deleted the pygetsetdef-eq branch June 19, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tpt @davidhewitt