Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dedicated US inputs #172

Merged
merged 24 commits into from
Feb 18, 2025

Conversation

finozzifa
Copy link
Contributor

@finozzifa finozzifa commented Jan 27, 2025

Changes proposed in this Pull Request

This PR addresses some of the concerns expressed by @fneum in the comment to the pull-request.

The PR proposes the following changes. Namely, it

  • relocates adjust_for_inflation from scripts/compile_cost_assumptions.py to _scripts/helpers.py. The function is fact now also needed in scripts/compile_cost_assumptions_usa.py
  • creates the sub-folder inputs/US where the US specific inputs used in scripts/compile_cost_assumptions_usa.py are stored
  • restores manual_input.csv to its state before the pull-request, with the exception of the changes
< methanol-to-olefins/aromatics,VOM,2015,30,EUR/t_HVC,2015,"DECHEMA 2017: DECHEMA: Low carbon energy and feedstock for the European chemical industry (https://dechema.de/dechema_media/Downloads/Positionspapiere/Technology_study_Low_carbon_energy_and_feedstock_for_the_European_chemical_industry.pdf), Table 35", 
---
> methanol-to-olefins/aromatics,VOM,2015,30,€/t_HVC,2015,"DECHEMA 2017: DECHEMA: Low carbon energy and feedstock for the European chemical industry (https://dechema.de/dechema_media/Downloads/Positionspapiere/Technology_study_Low_carbon_energy_and_feedstock_for_the_European_chemical_industry.pdf), Table 35", 
196c196
< electric steam cracker,VOM,2015,180,EUR/t_HVC,2015,"DECHEMA 2017: DECHEMA: Low carbon energy and feedstock for the European chemical industry (https://dechema.de/dechema_media/Downloads/Positionspapiere/Technology_study_Low_carbon_energy_and_feedstock_for_the_European_chemical_industry.pdf), Table 35",
---
> electric steam cracker,VOM,2015,180,€/t_HVC,2015,"DECHEMA 2017: DECHEMA: Low carbon energy and feedstock for the European chemical industry (https://dechema.de/dechema_media/Downloads/Positionspapiere/Technology_study_Low_carbon_energy_and_feedstock_for_the_European_chemical_industry.pdf), Table 35",
347c347
< coal,efficiency,2020,0.356,p.u.,2023,"Lazard's levelized cost of energy analysis - version 16.0 (2023): https://www.lazard.com/media/typdgxmm/lazards-lcoeplus-april-2023.pdf , pg. 49 (Levelized Cost of Energy - Key Assumptions), accessed: 2023-12-14.","Calculated based on average of listed range, i.e. 1 / ((8.75+12) MMbtu/MWh_th /2 / (3.4095 MMbtu/MWh_th)), rounded up."
---
> coal,efficiency,2020,0.33,p.u.,2023,"Lazard's levelized cost of energy analysis - version 16.0 (2023): https://www.lazard.com/media/typdgxmm/lazards-lcoeplus-april-2023.pdf , pg. 49 (Levelized Cost of Energy - Key Assumptions), accessed: 2023-12-14.","Calculated based on average of listed range, i.e. 1 / ((8.75+12) MMbtu/MWh_th /2 / (3.4095 MMbtu/MWh_th)), rounded up."

  • adds the technologies formerly added to manual_input.csv in the pull-request to inputs/US/manual_input_usa.csv
  • modifies scripts/compile_cost_assumptions_usa.csv to yield the same results obtained in the pull-request, but with the US specific technologies now listed in manual_input_usa.csv
  • updates the unit tests

Tests

The output files generated by scripts/compile_cost_assumptions.py are compared to the ones available at commit (the commit is the one that pre-dates the merge of the pull-request). The comparison is available in the attached file comparison.txt

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@finozzifa finozzifa marked this pull request as ready for review January 29, 2025 12:04
@finozzifa
Copy link
Contributor Author

Hi @lkstrp, thanks for your support :)

I believe that once this PR is merged, we will need a new (minor) release.

Thanks :)

Fabrizio

@lkstrp lkstrp requested a review from fneum January 29, 2025 12:16
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

At some point we need to discuss:

  1. moving data inputs out of the repository into a zenodo or alternative data store
  2. moving the outputs out of the repository into a zenodo (with an automated release pipeline for US and EU specific data
  3. structurally, it would be nicer to have a config that toggles between EU/US/global rather than two separate rules for compiling the data.

But these points are not directly relevant for this PR.

nrel_atb_input_discount_rate="inputs/discount_rates_usa.csv",
nrel_atb_input_fuel_costs="inputs/fuel_costs_usa.csv",
nrel_atb_manual_input_usa="inputs/US/manual_input_usa.csv",
eur_inflation_rate="inputs/prc_hicp_aind__custom_9928419_spreadsheet.xlsx",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly relevant for this PR, but these inflation rates are for Europe and should probably be substituted by a US-specific dataset.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fneum,
I agree and we should find it ASAP on the dedicated US website before the information gets deleted.
I will raise (yet) another PR.
Thanks!

@fneum fneum merged commit 3d238ee into PyPSA:master Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants