-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dedicated US inputs #172
Create dedicated US inputs #172
Conversation
…o create_dedicated_us_inputs
Hi @lkstrp, thanks for your support :) I believe that once this PR is merged, we will need a new (minor) release. Thanks :) Fabrizio |
…o create_dedicated_us_inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
At some point we need to discuss:
- moving data inputs out of the repository into a zenodo or alternative data store
- moving the outputs out of the repository into a zenodo (with an automated release pipeline for US and EU specific data
- structurally, it would be nicer to have a config that toggles between EU/US/global rather than two separate rules for compiling the data.
But these points are not directly relevant for this PR.
nrel_atb_input_discount_rate="inputs/discount_rates_usa.csv", | ||
nrel_atb_input_fuel_costs="inputs/fuel_costs_usa.csv", | ||
nrel_atb_manual_input_usa="inputs/US/manual_input_usa.csv", | ||
eur_inflation_rate="inputs/prc_hicp_aind__custom_9928419_spreadsheet.xlsx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly relevant for this PR, but these inflation rates are for Europe and should probably be substituted by a US-specific dataset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fneum,
I agree and we should find it ASAP on the dedicated US website before the information gets deleted.
I will raise (yet) another PR.
Thanks!
Changes proposed in this Pull Request
This PR addresses some of the concerns expressed by @fneum in the comment to the pull-request.
The PR proposes the following changes. Namely, it
Tests
The output files generated by scripts/compile_cost_assumptions.py are compared to the ones available at commit (the commit is the one that pre-dates the merge of the pull-request). The comparison is available in the attached file comparison.txt
Checklist
doc
.environment.yaml
(if applicable).doc/release_notes.rst
of the upcoming release is included.