Support of new training process #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parzival-05
force-pushed
the
david/model-validation
branch
2 times, most recently
from
fed64b7 to
615a7c1
Compare
Parzival-05
force-pushed
the
david/gpu-support
branch
from
b2add77 to
4147660
Compare
gsvgit
reviewed
Dec 28, 2024
Parzival-05
force-pushed
the
david/model-validation
branch
from
946a8d9 to
783ba3e
Compare
Parzival-05
force-pushed
the
david/model-validation
branch
from
41cd1b8 to
f732fb4
Compare
Parzival-05
force-pushed
the
david/model-validation
branch
2 times, most recently
from
02c7e74 to
46b9b42
Compare
Parzival-05
force-pushed
the
david/model-validation
branch
from
35432c6 to
05b0bc4
Compare
Parzival-05
force-pushed
the
david/gpu-support
branch
from
a49b0ed to
c2a86ca
Compare
Parzival-05
force-pushed
the
david/model-validation
branch
from
e73ad5e to
0ba658d
Compare
gsvgit
reviewed
Feb 21, 2025
Parzival-05
force-pushed
the
david/model-validation
branch
4 times, most recently
from
954fdb8 to
c9728c8
Compare
Parzival-05
force-pushed
the
david/gpu-support
branch
from
c2a86ca to
a2d6970
Compare
Parzival-05
force-pushed
the
david/model-validation
branch
from
d0d01d6 to
022aa4c
Compare
Parzival-05
force-pushed
the
david/model-validation
branch
from
022aa4c to
9f9b36b
Compare
gsvgit
requested changes
Mar 11, 2025
| @@ -227,9 +214,6 @@ private class TestSvmCommand : DelegatingTestCommand | |||
| private readonly ExplorationMode _explorationMode; | |||
| private readonly int _randomSeed; | |||
| private readonly uint _stepsLimit; | |||
| private readonly string _pathToModel; | |||
There was a problem hiding this comment.
Why these parameters can be removed?
| let q = ResizeArray<_> () | ||
| let availableStates = HashSet<_> () | ||
| let updateGameState (delta: GameState) = | ||
| module GameUtils = |
There was a problem hiding this comment.
What is the reason to create this module?
| match mode with | ||
| | AIMode -> | ||
| match options.aiAgentTrainingOptions with | ||
| let useGPU = | ||
| options.useGPU.IsSome && options.useGPU.Value |
There was a problem hiding this comment.
What is the case when useGPU is none? Can we just use false as a default value for this field?
| match options.aiAgentTrainingOptions with | ||
| let useGPU = | ||
| options.useGPU.IsSome && options.useGPU.Value | ||
| let optimize = |
| @@ -55,6 +70,13 @@ type CliArguments = | |||
| "Mode to run application. Server --- to train network, Generator --- to generate data for training." | |||
| | OutFolder _ -> "Folder to store generated data." | |||
| | StepsToSerialize _ -> "Maximal number of steps for each method to serialize." | |||
| | Model _ -> """Path to ONNX model (use it for training in mode "SendModel")""" | |||
| | StepsToPlay _ -> """Steps to start""" | |||
There was a problem hiding this comment.
Detailed explanation in help should be provided. For all arguments.
| } | ||
|
|
||
| let mutable steps = [] | ||
| let stepSaver (aiGameStep: AIGameStep) = steps <- aiGameStep :: steps in |
| oracle = None | ||
| } | ||
|
|
||
| let mutable steps = [] |
| searchStrategy = SearchStrategy.AI, | ||
| solverTimeout = SOLVER_TIMEOUT_FOR_TRAINING, | ||
| stepsLimit = uint (stepsToPlay + stepsToStart), | ||
| aiOptions = (Some aiOptions |> Option.defaultValue Unchecked.defaultof<_>), |
There was a problem hiding this comment.
What is the magic |> Option.defaultValue Unchecked.defaultof<_>?
| @@ -328,7 +472,61 @@ let main args = | |||
| with e -> | |||
| printfn $"Failed on port {port}" | |||
| printfn $"{e.Message}" | |||
| | Mode.SendModel -> | |||
| let model = | |||
| match args.TryGetResult <@ Model @> with | |||
There was a problem hiding this comment.
Try to use GetResult with default value. Like here
| ) | ||
|
|
||
| let useGPU = | ||
| (args.TryGetResult <@ UseGPU @>).IsSome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.