Skip to content

fix: Role Edit TypeHint #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2025
Merged

fix: Role Edit TypeHint #2795

merged 4 commits into from
May 30, 2025

Conversation

Lumabots
Copy link
Contributor

@Lumabots Lumabots commented May 30, 2025 •
edited
Loading

Summary

remove the | None for the role edit typehint since it only return Role

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lumabots Lumabots requested a review from a team as a code owner May 30, 2025 05:23
@pullapprove4 pullapprove4 bot requested a review from Middledot May 30, 2025 05:23
@Lumabots
Copy link
Contributor Author

i dont think this needs a changelog

@Lulalaby Lulalaby merged commit a5b70e6 into Pycord-Development:master May 30, 2025
28 of 29 checks passed
plun1331 pushed a commit to Pycord-Test/pycord that referenced this pull request Jun 1, 2025
@Paillat-dev @Lumabots
@NeloBlivion @pre-commit-ci
chore: Merge upstream (#34)
5e605a4 
* fix: Role Edit TypeHint (Pycord-Development#2795)

Signed-off-by: Lumouille <[email protected]>

* fix: command syncing edge cases (Pycord-Development#2797)

* change default nsfw to false

* cl

* localizations

* :=

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Format code

---------

Signed-off-by: Lumouille <[email protected]>
Co-authored-by: Lumouille <[email protected]>
Co-authored-by: UK <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Awaiting requested review from Middledot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lumabots @Lulalaby