fix: command syncing edge cases #2797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeloBlivion
changed the title
Lulalaby
approved these changes
May 31, 2025
|
tbh i was meant to change this to draft because i found several more annoyances that seemingly were never tested but eh it hurts to read through this code... |
|
Oop |
plun1331
pushed a commit
to Pycord-Test/pycord
that referenced
this pull request
Jun 1, 2025
* fix: Role Edit TypeHint (Pycord-Development#2795) Signed-off-by: Lumouille <[email protected]> * fix: command syncing edge cases (Pycord-Development#2797) * change default nsfw to false * cl * localizations * := * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Format code --------- Signed-off-by: Lumouille <[email protected]> Co-authored-by: Lumouille <[email protected]> Co-authored-by: UK <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes some edge cases in desynced commands:
nsfwin command payloads, and as such it should not beNoneby default.name_localizationsanddescription_localizationsare falseyInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.