Skip to content

fix: VoiceClient crashes while receiving audio #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025

Conversation

Hema2-official
Copy link
Contributor

@Hema2-official Hema2-official commented Jun 3, 2025

Summary

I fixed issue #2644.
The problem was a length check taking place after byte checks.
I did extensive testing and it seems to completely get rid of the seemingly random crashes.
fixes: #2644

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Copy link
Contributor

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx for the fix

@Paillat-dev
Copy link
Contributor

@Hema2-official Please edit your message so that you have a line with the following format:

fixes: #2644

So that the pr is marked as fixing that issue

@Paillat-dev
Copy link
Contributor

image
Tf happened with readthedocs also, @Lulalaby can you try restarting that ?

@Paillat-dev
Copy link
Contributor

Paillat-dev commented Jun 3, 2025

Also @Hema2-official add a changelog under Fixed please, take a look at CHANGELOG.md

@JustaSqu1d
Copy link
Member

image

Tf happened with readthedocs also, @Lulalaby can you try restarting that ?

Github died, i guess

@Lulalaby
Copy link
Member

Lulalaby commented Jun 3, 2025

build is re-running

@Lulalaby
Copy link
Member

Lulalaby commented Jun 3, 2025

fkng rtd

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking my approval - Changelog needed

@Lulalaby Lulalaby added bug Something isn't working priority: low Low Priority hold: changelog This pull request is missing a changelog entry labels Jun 3, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Pycord Releases Jun 3, 2025
@Lulalaby Lulalaby added this to the v2.7 milestone Jun 3, 2025
@Lulalaby
Copy link
Member

Lulalaby commented Jun 3, 2025

We have to give up on the RTD CI for now. It seems like it doesn't report the status back anymore

Add the changelog @Hema2-official and we're good to go I'll bypass the reqs

@Paillat-dev
Copy link
Contributor

It just worked

@Lulalaby
Copy link
Member

Lulalaby commented Jun 3, 2025

I hate GitHub
hate

@Lulalaby Lulalaby removed the request for review from BobDotCom June 3, 2025 17:59
@Hema2-official
Copy link
Contributor Author

@Hema2-official Please edit your message so that you have a line with the following format:

Thanks for the edit, @Lulalaby 🫂

I'll add the changelog rq!

Signed-off-by: Hema2 <[email protected]>
@Hema2-official
Copy link
Contributor Author

Done, y'all can merge!
Thank you! <3

@Lulalaby Lulalaby enabled auto-merge (squash) June 3, 2025 18:37
@Lulalaby Lulalaby merged commit cd1531d into Pycord-Development:master Jun 3, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pycord Releases Jun 3, 2025
@Lulalaby Lulalaby removed the hold: changelog This pull request is missing a changelog entry label Jun 3, 2025
@Lulalaby Lulalaby linked an issue Jun 3, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: low Low Priority
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

"list index out of range" error when connecting to voice channel voice_client receiving voice errors / not working ?
4 participants