Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 19 - Add schedule support for single zone heating in Hive boiler module #36

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martintoreilly
Copy link
Contributor

Description

Adds support for getting and setting the weekly schedule for heating only for a central Hive heating boiler module with a single heating zone.

Implementation

  • Augment sync api.setState() function to handle dictionary states
  • Augment async api.setState() function to handle dictionary states
  • Add heating.getSchedule() function
  • Add heating.setSchedule() function

Tests

Scope

Partially addresses #19

Includes:

  • Schedule support for single heating zone for single central boiler module.

Excludes:

  • Schedule support for hot water
  • Schedule support for multiple heating zones
  • Schedule support for individual radiator TRVs

Use json.dumps(<properties_dictionary>) rather than hand-rolled JSON string construction code.
Use json.dumps(<properties_dictionary>) rather than hand-rolled JSON string construction code
@martintoreilly
Copy link
Contributor Author

api.setState() implementation

Replace custom code that iterates over kwarg dictionary and constructs JSON string with a call to json.dumps(kwargs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant