Fix for #104, adding support for mounted apps #244
Conversation
Interpolate request.script_name for openapi path_pattern to accomodate
…o fix/mounted-apps
|
Can you please add a functional test for this? |
goodwillcoding
changed the title
|
Hi @zupo. I cleaned up the fix and updated the existing test for The PR checks above fail on |
I'll have a look. |
| else self.request.path_info | ||
| ) | ||
|
|
||
| # since application might be mounted on virtual location we need |
There was a problem hiding this comment.
| # since application might be mounted on virtual location we need | |
| # Since application might be mounted on virtual location we need |
|
|
||
| # since application might be mounted on virtual location we need | ||
| # to prepend it to the route pattern, or request's response validation | ||
| # will fail. one example of this is using WSGI compositors like |
There was a problem hiding this comment.
| # will fail. one example of this is using WSGI compositors like | |
| # will fail. One example of this is using WSGI compositors like |
| path_pattern = "%s%s" % ( | ||
| self.request.script_name, | ||
| self.request.matched_route.pattern, | ||
| ) |
There was a problem hiding this comment.
| path_pattern = "%s%s" % ( | |
| self.request.script_name, | |
| self.request.matched_route.pattern, | |
| ) | |
| path_pattern = f"{self.request.script_name}{self.request.matched_route.pattern}" |
There was a problem hiding this comment.
This should also fix the pyupgrade warning.
|
Without realizing this PR was here I think I just reimplemented the same fix that @goodwillcoding had done in this PR over at #263. Mine is slightly different in that I didn't use |
No description provided.