-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from dependence on gurobi.sh #3384
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c828678
Refactor GUROBI_RUN to separate result parsing from writing the soln …
jsiirola 2c8f91f
Add a file-based direct interface (a thin veneer over the shell inter…
jsiirola 7f4a4ff
Explicitly release model in GUROBI_RUN
jsiirola 3587763
Prevent gurobipy_available from being resolved (even if it was alread…
jsiirola 9f579c2
NFC: apply black
jsiirola c664c68
guard import of GUROBI_RUN
jsiirola d6fc8ee
Remove pin on Gurobi version
jsiirola dffbbd5
NFC: apply black
jsiirola a03e5ce
Switch default mBigM solver to avoid triggering gurobipy import
jsiirola 040725e
Update contrib (appsi+solver) tests to reflect change in Gurobi behavior
jsiirola 5c01b97
Bugfix to test (copy/paste error)
jsiirola f820414
Implement GUROBIFILE available() and license_is_valid() checks
jsiirola 9f79d32
fix typo (copy/paste error)
jsiirola 1f6d126
Merge branch 'main' into gurobi-sh-deprecation
jsiirola 7f33e1d
Merge branch 'main' into gurobi-sh-deprecation
jsiirola f85117c
NFC: update comments
jsiirola 3981d2f
NFC: remove references to CPLEX
jsiirola ff6a733
Merge branch 'main' into gurobi-sh-deprecation
jsiirola 83aa22a
Add missing import
jsiirola 24bee9f
Capture gurobi output sent to the underlying stdout file handle
jsiirola fd18342
NFC: apply black
jsiirola 525dc6c
Merge branch 'main' into gurobi-sh-deprecation
jsiirola f6e2822
Leverage deferred config resolution for mbigm solver
jsiirola 6aeba60
Merge branch 'main' into gurobi-sh-deprecation
blnicho fec1416
Merge branch 'main' into gurobi-sh-deprecation
mrmundt 7fd605c
Remove reference to pyutilib
jsiirola f28d7e6
Skip gurobipy profile lines
jsiirola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #3394 has been merged can the changes in this file be reverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I just noticed the last commit message which seems to already be using the deferred config stuff so ignore my original question. Is the
Solver
domain implemented here general enough to go intopyomo.common
orpyomo.util
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty general, but could use some discussion before promulgating it elsewhere. In particular, what is the "correct" way to know if you were handed a "solver" object? Given that we have 3 different base classes floating around (core, APPSI, and contrib/solver), inheritance is probably not the right answer. This implementation just looks for a
solve()
method and hopes it quacks.