Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename project "pyomo" in setup.py [PEP 625] #3430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

PyPI is rejecting Pyomo wheels because the project name was capitalized. This resolves that error.

Changes proposed in this PR:

  • rename "Pyomo" -> "pyomo"

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho
Copy link
Member

blnicho commented Nov 19, 2024

I kicked off the wheel builder GHA workflow on this branch: https://github.com/blnicho/pyomo/actions/runs/11903047078

I'm not really sure how to check if these wheels satisfy PEP 625 or if we still need this PR since PyPI reverted the strict enforcement of the PEP.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (038f38b) to head (be24275).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
+ Coverage   88.66%   88.71%   +0.04%     
==========================================
  Files         882      882              
  Lines      100623   100623              
==========================================
+ Hits        89216    89265      +49     
+ Misses      11407    11358      -49     
Flag Coverage Δ
linux 86.17% <ø> (+<0.01%) ⬆️
osx 76.19% <ø> (ø)
other 86.66% <ø> (+<0.01%) ⬆️
win 84.55% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants