Update PyROS Uncertainty Set Validation Methods #3558
+1,549
−607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsiirola @shermanjasonaf Thank you for all of your feedback! I have addressed most comments, with the remaining being mostly related to rewriting the |
|
@shermanjasonaf @jsiirola I have addressed all comments. I would appreciate further feedback on my implementations for |
blnicho
reviewed
Jul 3, 2025
| # check when values are not finite | ||
| cardinality_set.origin[0] = np.nan | ||
| exc_str = ( | ||
| r"Entry 'nan' of the argument `origin` " r"is not a finite numeric value" |
There was a problem hiding this comment.
Suggested change
| r"Entry 'nan' of the argument `origin` " r"is not a finite numeric value" | |
| r"Entry 'nan' of the argument `origin` is not a finite numeric value" |
| # check when values are not finite | ||
| a_ellipsoid_set.center[0] = np.nan | ||
| exc_str = ( | ||
| r"Entry 'nan' of the argument `center` " r"is not a finite numeric value" |
There was a problem hiding this comment.
Suggested change
| r"Entry 'nan' of the argument `center` " r"is not a finite numeric value" | |
| r"Entry 'nan' of the argument `center` is not a finite numeric value" |
| # check when values are not finite | ||
| ellipsoid_set.center[0] = np.nan | ||
| exc_str = ( | ||
| r"Entry 'nan' of the argument `center` " r"is not a finite numeric value" |
There was a problem hiding this comment.
Suggested change
| r"Entry 'nan' of the argument `center` " r"is not a finite numeric value" | |
| r"Entry 'nan' of the argument `center` is not a finite numeric value" |
| # check when values are not finite | ||
| polyhedral_set.rhs_vec[0] = np.nan | ||
| exc_str = ( | ||
| r"Entry 'nan' of the argument `rhs_vec` " r"is not a finite numeric value" |
There was a problem hiding this comment.
Suggested change
| r"Entry 'nan' of the argument `rhs_vec` " r"is not a finite numeric value" | |
| r"Entry 'nan' of the argument `rhs_vec` is not a finite numeric value" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2724, #3508
Summary/Motivation:
This PR provides updates to PyROS uncertainty set validation methods and related tests.
Here, a
validatemethod replaces theis_validmethod (which solves 2N bounding problems to check for set boundedness) in all uncertainty sets, with each set having its own customvalidatemethod that efficiently checks set-specific attributes and raises informative exceptions if any issues are found.Changes proposed in this PR:
is_boundedandis_nonemptymethods in baseUncertaintySetclass_solve_feasibilitymethod in baseUncertaintySetclassis_validwithvalidatemethod that runsis_boundedandis_nonemptyin the baseUncertaintySetclassvalidatein subclass uncertainty sets to check set-specific attributesvalidatemethodis_bounded,is_nonempty,_solve_feasibility, andvalidatemethodsTODO
_compute_parameter_boundsvalidate_arrayto allvalidatemethodstest_validatetests into separate tests for each validation check_validatemethod forPolyhedralSetLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: