-
Notifications
You must be signed in to change notification settings - Fork 546
Add external function library #3648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 889 891 +2
Lines 102486 102499 +13
=======================================
+ Hits 91144 91161 +17
+ Misses 11342 11338 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@unittest.skipUnless(flib, 'Could not find the "external" library') | ||
class TestAMPLExternalFunction(unittest.TestCase): | ||
|
||
@unittest.skipIf(is_pypy, "Cannot evaluate external functions under pypy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not move this to the class level rather than put it on every single test?
Fixes None
Summary/Motivation:
Add and external function library for useful functions that are not easily implemented as Pyomo expressions.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: