-
Notifications
You must be signed in to change notification settings - Fork 546
Make exporting of PyROS subproblems more customizable #3649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make exporting of PyROS subproblems more customizable #3649
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3649 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 888 888
Lines 102455 102451 -4
=======================================
+ Hits 91127 91129 +2
+ Misses 11328 11322 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love reductions of duplicate code. Looks good!
Summary/Motivation:
The PyROS solver provides two optional arguments
keepfiles
andsubproblem_file_directory
for specifying whether and where subproblems that were not solved to an acceptable level are to be written. However, when subproblems are written, they are exclusively written in'bar'
format. Other formats ('gams'
,'nl'
, etc.) may be of interest to the user.Changes proposed in this PR:
subproblem_format_options
. This argument should be (castable to) adict
object, of which each entry maps a PyomoWriterFactory
format (e.g.,'bar'
,'gams'
) to a value for the argumentio_options
toBlockData.write()
.TODO (after #3646 merged)
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: