Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrchardZSA backward compatability using traits #31

Merged
merged 123 commits into from
Aug 8, 2024
Merged

OrchardZSA backward compatability using traits #31

merged 123 commits into from
Aug 8, 2024

Commits on Apr 23, 2024

  1. add initial doc

    YaoGalteland committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    80dfd60 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. clean up code

    YaoGalteland committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d3a6f42 View commit details
    Browse the repository at this point in the history

  2. remove cfg[test]

    YaoGalteland committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    86bd33f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. remove generator table trait, fix hash_to_point

    YaoGalteland committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    989f29b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. update code for hash

    YaoGalteland committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    507a53c View commit details
    Browse the repository at this point in the history

  2. fmt

    YaoGalteland committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2e31e97 View commit details
    Browse the repository at this point in the history

  3. fix run tests error

    YaoGalteland committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b02478a View commit details
    Browse the repository at this point in the history

  4. minor update

    YaoGalteland committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e6d1dbe View commit details
    Browse the repository at this point in the history

  5. test error

    YaoGalteland committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    23a2951 View commit details
    Browse the repository at this point in the history

  6. Revert "test error" 

    This reverts commit 23a2951.
    YaoGalteland committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    301e7d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. re-naming structs and functions

    YaoGalteland committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c324006 View commit details
    Browse the repository at this point in the history

  2. fix complex type

    YaoGalteland committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    af29df4 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. add round trip test to verify that the pinned verification key (repre… 

    …senting the circuit) is as expected
    YaoGalteland committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1ea04bb View commit details
    Browse the repository at this point in the history

  2. update serialized_proof_test_case

    YaoGalteland committed May 6, 2024
    Configuration menu
    Copy the full SHA
    684c13e View commit details
    Browse the repository at this point in the history

  3. update

    YaoGalteland committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a25a6ad View commit details
    Browse the repository at this point in the history

  4. update short lookup test

    YaoGalteland committed May 6, 2024
    Configuration menu
    Copy the full SHA
    42f1b0a View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    YaoGalteland committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2b89fae View commit details
    Browse the repository at this point in the history

  6. fix Clippy error

    YaoGalteland committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8552c97 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. clean up code

    YaoGalteland committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f35cbe9 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. add initial files

    YaoGalteland committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f65d5a3 View commit details
    Browse the repository at this point in the history

  2. minor update

    YaoGalteland committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7e50d0b View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. remove pub(crate) in ecc

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    58f8b3f View commit details
    Browse the repository at this point in the history

  2. add a line after cargo.toml

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    738eabe View commit details
    Browse the repository at this point in the history

  3. add a line after cargo.toml

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0fb6dd4 View commit details
    Browse the repository at this point in the history

  4. slide lines in base_field_elem

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e2c9c30 View commit details
    Browse the repository at this point in the history

  5. slide lines in base_field_elem

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5322c81 View commit details
    Browse the repository at this point in the history

  6. adjuct function orders for configure in sinsemilla/chip

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    46773e3 View commit details
    Browse the repository at this point in the history

  7. adjuct function orders for hash_message

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3621e0e View commit details
    Browse the repository at this point in the history

  8. adjuct function orders for hash_message

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a30596b View commit details
    Browse the repository at this point in the history

  9. cleanup code

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b3cb453 View commit details
    Browse the repository at this point in the history

  10. cleanup code

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    cf2bd37 View commit details
    Browse the repository at this point in the history

  11. cleanup code

    YaoGalteland committed May 13, 2024
    Configuration menu
    Copy the full SHA
    da85c71 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. resolve review

    YaoGalteland committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a5bf5ee View commit details
    Browse the repository at this point in the history

  2. Introduce conditionally_save_circuit_to_disk function to reuse the pr… 

    …oof saving code in test cases
    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8d27dd7 View commit details
    Browse the repository at this point in the history

  3. Rename conditionally_save_circuit_to_disk function to conditionally_s… 

    …ave_proof_to_disk
    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    48f941e View commit details
    Browse the repository at this point in the history

  4. Introduce test_serialized_proof_with_vk and test_serialized_proof fun… 

    …ctions to reuse them and so avoid code duplication in serialized_proof_test_case tests
    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    58b7eff View commit details
    Browse the repository at this point in the history

  5. Fix cargo clippy error

    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    756bb78 View commit details
    Browse the repository at this point in the history

  6. rename

    YaoGalteland committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6814fc2 View commit details
    Browse the repository at this point in the history

  7. fix git error

    YaoGalteland committed May 14, 2024
    Configuration menu
    Copy the full SHA
    64a8ac2 View commit details
    Browse the repository at this point in the history

  8. Move all test .bin files and test_circuit.rs module to new tests fold… 

    …er in the root of src
    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    704d3f6 View commit details
    Browse the repository at this point in the history

  9. Add missed files

    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d0d3a6f View commit details
    Browse the repository at this point in the history

  10. Move all .bin and vk_ test data files into src/tests folder

    @dmidem
    dmidem committed May 14, 2024
    Configuration menu
    Copy the full SHA
    35f161d View commit details
    Browse the repository at this point in the history

  11. add tests for short range check

    YaoGalteland committed May 14, 2024
    Configuration menu
    Copy the full SHA
    497c290 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Add fixed_verification_key_test_with_circuit function to generalize V… 

    …K tests like the proof tests are generalized with serialized_proof_test_case_with_circuit
    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d3a9d4e View commit details
    Browse the repository at this point in the history

  2. Avoid duplicating test data folder name src/tests in every file name,… 

    … use TEST_DATA_DIR const in test module instead (make the full file name from the fiule names passed, the dir name const and extention (bin for proofs)
    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cf8aca0 View commit details
    Browse the repository at this point in the history

  3. Remove 'else' in fixed_verification_key_test_with_circuit function, t… 

    …o read after write if env var set and so check the writing
    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b7c7261 View commit details
    Browse the repository at this point in the history

  4. Use fs::read, fs::write instad of read_test_case and write_test_case

    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d3c7eb0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'improve-backward-compatability-without-zsa' of github.c… 

    …om:QED-it/halo2 into improve-backward-compatability-without-zsa
    YaoGalteland committed May 15, 2024
    Configuration menu
    Copy the full SHA
    af5fd9c View commit details
    Browse the repository at this point in the history

  6. revert .github/workflows/ci.yml

    YaoGalteland committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5248a0a View commit details
    Browse the repository at this point in the history

  7. rename circuit.rs

    YaoGalteland committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8a68152 View commit details
    Browse the repository at this point in the history

  8. add a line

    YaoGalteland committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8dbb582 View commit details
    Browse the repository at this point in the history

  9. fix ci.yml

    YaoGalteland committed May 15, 2024
    Configuration menu
    Copy the full SHA
    32842df View commit details
    Browse the repository at this point in the history

  10. Rename PallasLookupRC LookupRangeCheck trait alias to PallasLookup. A… 

    …dd and use PallasLookupConfig type alias for LookupRangeCheckConfigspecialized with pallas::Base and sinsemilla::K
    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3324348 View commit details
    Browse the repository at this point in the history

  11. Move circuit test data to tests/circuit_reference_data folder, fix na… 

    …mes of the test data files to follow the same convention: .proof.bin for proof tests, .vk.txt for verifying key/layout tests
    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    92922be View commit details
    Browse the repository at this point in the history

  12. Rename circuit_reference_data to circuit_data

    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6c7713f View commit details
    Browse the repository at this point in the history

  13. Fix cargo fmt issues

    @dmidem
    dmidem committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8922ed6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Try to increase cargo-tarpaulin timeout in ci.yml from 600 to 1800 to… 

    … see if it helps to resolve test failing on GitHub
    @dmidem
    dmidem committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f75b054 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Add default generic arguments for PallasLookup to improve backward co… 

    …mpatibility

This change adds default generic arguments for types implementing the PallasLookup trait,
assigning them to PallasLookupConfig by default. This adjustment allows existing code to
function without requiring users to explicitly specify PallasLookupConfig, thus minimizing
breaking changes. Users will still need to bring the PallasLookup trait into scope using
'use ... PallasLookup'.
    @dmidem
    dmidem committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5414d95 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Try to increase cargo-tarpaulin timeout in ci.yml from to 3600

    @dmidem
    dmidem committed May 22, 2024
    Configuration menu
    Copy the full SHA
    396bbde View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. update

    YaoGalteland committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1ae0a31 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    YaoGalteland committed May 28, 2024
    Configuration menu
    Copy the full SHA
    adf4d0d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'improve-backward-compatability-without-zsa-default-gene… 

    …ric-arg' into improve-backward-compatability-without-zsa
    @dmidem
    dmidem committed May 28, 2024
    Configuration menu
    Copy the full SHA
    807304d View commit details
    Browse the repository at this point in the history

  4. add index to proofs

    YaoGalteland committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1bb0b84 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. rename PallasLookupRC10b to PallasLookupRCConfig

    YaoGalteland committed May 30, 2024
    Configuration menu
    Copy the full SHA
    923293b View commit details
    Browse the repository at this point in the history

  2. resolve some comments

    YaoGalteland committed May 30, 2024
    Configuration menu
    Copy the full SHA
    9ecbd65 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. add zsa feature

    YaoGalteland committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9337142 View commit details
    Browse the repository at this point in the history

  2. fix cargo clippy

    YaoGalteland committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8a8aca2 View commit details
    Browse the repository at this point in the history

  3. fix shrot test

    YaoGalteland committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4de57c1 View commit details
    Browse the repository at this point in the history

  4. add some docs

    YaoGalteland committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1c694c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fix error in ci.yml

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    aedcc54 View commit details
    Browse the repository at this point in the history

  2. remove space in ci.yml

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b252579 View commit details
    Browse the repository at this point in the history

  3. order functions in hash_to_point

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ce24e86 View commit details
    Browse the repository at this point in the history

  4. order functions in hash_to_point

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5474c7c View commit details
    Browse the repository at this point in the history

  5. crate -> super

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1cac5b7 View commit details
    Browse the repository at this point in the history

  6. re-order cond_swap and lookup

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ddee3ed View commit details
    Browse the repository at this point in the history

  7. re-order cond_swap

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    637abbc View commit details
    Browse the repository at this point in the history

  8. remove crate for configure_with_tag

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9cef0b0 View commit details
    Browse the repository at this point in the history

  9. lookup tests update

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f69907b View commit details
    Browse the repository at this point in the history

  10. change sinsemillachip to sinsemillachipOptimized

    YaoGalteland committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9b4c51f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Cleanup code and some renamings

    @ConstanceBeguier
    ConstanceBeguier committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2069bd1 View commit details
    Browse the repository at this point in the history

  2. rust fmt

    @ConstanceBeguier
    ConstanceBeguier committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1a21413 View commit details
    Browse the repository at this point in the history

  3. Remove EccInstructionsOptimized

    @ConstanceBeguier
    ConstanceBeguier committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    de56201 View commit details
    Browse the repository at this point in the history

  4. Remove dead_code flag on EccPointQ

    @ConstanceBeguier
    ConstanceBeguier committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    52e6fbb View commit details
    Browse the repository at this point in the history

  5. Remove CondSwapInstructionsOptimized

    @ConstanceBeguier
    ConstanceBeguier committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8d13e7a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Clean imports

    @ConstanceBeguier
    ConstanceBeguier committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    36a9319 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Remove redundancy in lookup_range_check tests

    @ConstanceBeguier
    ConstanceBeguier committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6cab338 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Save test files for optimized lookup range check

    @ConstanceBeguier
    ConstanceBeguier committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    474cfac View commit details
    Browse the repository at this point in the history

  2. Fix test_against_stored_ecc_chip_4_5_b

    @ConstanceBeguier
    ConstanceBeguier committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ce807ea View commit details
    Browse the repository at this point in the history

  3. Put together test_against_stored_vk/proof into test_against_stored_ci… 

    …rcuit

Previously, the functions test_against_stored_vk and test_against_stored_proof
each generated a verification key (vk). This operation can be quite slow.
We are combining these two tests to generate the vk only once.
    @ConstanceBeguier
    ConstanceBeguier committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8c55c6f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Add test on mul_sign for non optimized lookup

    @ConstanceBeguier
    ConstanceBeguier committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c9d8006 View commit details
    Browse the repository at this point in the history

  2. Remove redundancy in ecc tests

    @ConstanceBeguier
    ConstanceBeguier committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    06746f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Add expected_proof_size in test_against_stored_circuit

    @ConstanceBeguier
    ConstanceBeguier committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    36e03e3 View commit details
    Browse the repository at this point in the history

  2. Fix Merkle tests with optimized lookup

    @ConstanceBeguier
    ConstanceBeguier committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    5623a78 View commit details
    Browse the repository at this point in the history

  3. Rename layout images for circuits with optimized lookup

    @ConstanceBeguier
    ConstanceBeguier committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    2c1f636 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Remove redundancy in mul_fixed short tests

    @ConstanceBeguier
    ConstanceBeguier committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ac71097 View commit details
    Browse the repository at this point in the history

  2. Move load_with_tag

    @ConstanceBeguier
    ConstanceBeguier committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    61d223e View commit details
    Browse the repository at this point in the history

  3. Light modifications on hash_to_point

    @ConstanceBeguier
    ConstanceBeguier committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b4a70ab View commit details
    Browse the repository at this point in the history

  4. Add test on mux with non optimized lookup

    @ConstanceBeguier
    ConstanceBeguier committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a208dca View commit details
    Browse the repository at this point in the history

  5. Rename some lookup traits and structures 

    LookupRangeCheck45BConfig       <- LookupRangeCheckConfigOptimized
PallasLookupRangeCheck          <- PallasLookupRC
PallasLookupRangeCheckConfig    <- PallasLookupRCConfig
PallasLookupRangeCheck45BConfig <- PallasLookupConfigOptimized
    @ConstanceBeguier
    ConstanceBeguier committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fda20b9 View commit details
    Browse the repository at this point in the history

  6. Rename Sinsemilla/MerkleChipOptimized 

    Sinsemilla45BChip         <- SinsemillaChipOptimized
Sinsemilla45BInstructions <- SinsemillaInstructionsOptimized
Merkle45BChip             <- MerkleChipOptimized
    @ConstanceBeguier
    ConstanceBeguier committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cd4d43a View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Put together some imports

    @ConstanceBeguier
    ConstanceBeguier committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    18e3e0d View commit details
    Browse the repository at this point in the history

  2. Fix LookupangeCheck loading in Sinsemilla 

    Previously, the SinsemillaChip always loaded the lookup range check
without tag column and Sinsemilla45BChip always loaded the lookup
range check with tag column.
Now, we load lookup range check with or without tag according to the
lookup type (LookupRangeCheckConfig or LookupRangeCheck45BConfig).
    @ConstanceBeguier
    ConstanceBeguier committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d6bcf3b View commit details
    Browse the repository at this point in the history

  3. Fix Sinsemilla45BChip and Merkle45BChip 

    It is now possible to use Sinsemilla/Merkle45BChip with non optimized lookup.
    @ConstanceBeguier
    ConstanceBeguier committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b5d8916 View commit details
    Browse the repository at this point in the history

  4. Rename Sinsemilla/Merkle45BChip 

    SinsemillaWithPrivateInitChip <- Sinsemilla45BChip
SinsemillaWithPrivateInitInstructions <- Sinsemilla45BInstructions
MerkleWithPrivateInitChip <- Merkle45BChip
    @ConstanceBeguier
    ConstanceBeguier committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1fbc7de View commit details
    Browse the repository at this point in the history

  5. Clean lookup range check tests

    @ConstanceBeguier
    ConstanceBeguier committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    37e9380 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Rename some layouter images

    @ConstanceBeguier
    ConstanceBeguier committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    eda965f View commit details
    Browse the repository at this point in the history

  2. Update some comments

    @ConstanceBeguier
    ConstanceBeguier committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6af9ebf View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Simplify Sinsemilla/Merkle chips thanks to enable_hash_from_private_p… 

    …oint variable

We add enable_hash_from_private_point into SinsemillaChip in order to
put together SinsemillaChip and SinsemillaWithPrivateInitChip.
If enable_hash_from_private_point is set, it is possible to hash from
a private point. Otherwise, it is not allowed.
That allows also to put together MerkleChip and
MerkleWithPrivateInitChip.
    @ConstanceBeguier
    ConstanceBeguier committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2021f5e View commit details
    Browse the repository at this point in the history

  2. Refactoring

    @ConstanceBeguier
    ConstanceBeguier committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0d2512a View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Refactor

    @ConstanceBeguier
    ConstanceBeguier committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e2c9e93 View commit details
    Browse the repository at this point in the history

  2. Remove MerkleSinsemillaInstructions

    @ConstanceBeguier
    ConstanceBeguier committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7f5c0ba View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Restore code coverage

    @ConstanceBeguier
    ConstanceBeguier committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    41c7d2e View commit details
    Browse the repository at this point in the history

  2. Refactor

    @ConstanceBeguier
    ConstanceBeguier committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9c29f27 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Remove redundancy in Merkle tests

    @ConstanceBeguier
    ConstanceBeguier committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    714fff0 View commit details
    Browse the repository at this point in the history

  2. Rename MyCircuit into MyMagnitudeSignCircuit on fixed_mul/short tests

    @ConstanceBeguier
    ConstanceBeguier committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    70af809 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Refactor

    @ConstanceBeguier
    ConstanceBeguier committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    68d65e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Make cond_swap_config public in merkle_config

    @ConstanceBeguier
    ConstanceBeguier committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a8832c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Take into account Pablo's review

    @ConstanceBeguier
    ConstanceBeguier committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8a2cbee View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Take into account Pablo's review

    @ConstanceBeguier
    ConstanceBeguier committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    03dbe70 View commit details
    Browse the repository at this point in the history

  2. Some renamings

    @ConstanceBeguier
    ConstanceBeguier committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a34d146 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Replace enable_hash_from_private_point by init_from_private_point

    @ConstanceBeguier
    ConstanceBeguier committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9df4fb6 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary changes in CI

    @ConstanceBeguier
    ConstanceBeguier committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    493bf53 View commit details
    Browse the repository at this point in the history

  3. Rename Error::HashFromPrivatePoint to Error::IllegalHashFromPrivatePoint

    @ConstanceBeguier
    ConstanceBeguier committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    46db5d4 View commit details
    Browse the repository at this point in the history