Fix LongRange unit test issue and adjust MPC reference value. #5382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test this please. |
prckent
approved these changes
Mar 16, 2025
Contributor
|
Test this please |
prckent
added a commit
to prckent/qmcpack
that referenced
this pull request
Apr 7, 2025
prckent
added a commit
to prckent/qmcpack
that referenced
this pull request
Apr 7, 2025
ye-luo
added a commit
that referenced
this pull request
Apr 7, 2025
Reinstall #5382 (deterministic-diamondC_1x1x1_pp-multi_dmc_sdj-1-1-2-mpc related fixes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I took a close look at the issue raised by #5374
It seems to be
-ffast-mathrelated when compilingsrc/Particle/LongRange/tests/test_StructFact.cpp.I found a workaround by doing reduction in double precision in the unit test.
This PR also fixes #5377
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist