Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tribe of Tjernobyl mode #362

Closed
wants to merge 4 commits into from
Closed

Conversation

dusty-qw
Copy link
Contributor

@dusty-qw dusty-qw commented Aug 31, 2024

ToT is a bot FFA practice mode created by slime (https://github.com/osm/ktx/tree/tot).
There is an MVDSV PR that goes along with this (so you can see bot skill in the scoreboard in ping column).

ToT is a dmm4 1v8 bot game. You spawn with full health and unlimited ammo while the bots spawn with no armor and only shotguns. The goal is to frag as many bots as possible before dying, up to a 5 minute limit. Powerups are enabled.

To play (e1m2 is a good map for this):
/tot
/botcmd enable
/botcmd fill 20
/ready

@@ -406,9 +406,9 @@ intptr_t trap_Map_Extension(const char *ext_name, intptr_t mapto)
return syscall(G_Map_Extension, (intptr_t) ext_name, mapto);
}

intptr_t trap_AddBot(const char *name, intptr_t bottomcolor, intptr_t topcolor, const char *skin)
intptr_t trap_AddBot(const char *name, intptr_t bottomcolor, intptr_t topcolor, const char *skin, intptr_t skill)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To quote @qqshka

Not sure we really need bot skill as a ping, probably can just set user info key for bot, skill or something

Here's a sample of how it works with team/topcolor/bottomcolor:
https://github.com/QW-Group/ktx/blob/master/src/vote.c#L715-L717

Although mvdsv has this comment:

// FIXME: Why PR2_UserInfoChanged is not called here? Like for normal players.
//        Why we need this special handling in the first place?

So perhaps the regular userinfo, check with someone who knows more.

Copy link
Contributor Author

@dusty-qw dusty-qw Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the purpose of showing bot skill in ping column is so you can see from the endgame screenshot that the proper skill was used to achieve your score. I suppose it can be removed entirely if that's not a concern.

@tcsabina
Copy link
Collaborator

tcsabina commented Sep 1, 2024

Hi @dusty-qw,

Can you add a bit more explanation/documentation about what does this mod actually do? You know, a small 'readme' or something...

Thanks!

@tcsabina
Copy link
Collaborator

tcsabina commented Sep 1, 2024

And dusty, you need to fix the builds... ;)
We need those (void) parameter lists...

@dsvensson
Copy link
Collaborator

...and fortunately there's also CI for QVM nowadays, and the CI runs in your repo as well so check the result there:

https://github.com/dusty-qw/ktx/actions/runs/10652618687/job/29526713483

@tcsabina
Copy link
Collaborator

tcsabina commented Sep 1, 2024

@dusty-qw,

Had a short internal chat on this one, and the 'skill' as 'ping' is something that we don't really like, as qqshka indicated...

Could you come up with some clever ways to show the bot's skill during a match, and at the endgame stats as well? Maybe add it to the bot's name, or something?

@dusty-qw dusty-qw closed this Sep 19, 2024
@dusty-qw dusty-qw deleted the tot-merge-2 branch November 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants