-
Notifications
You must be signed in to change notification settings - Fork 6
Allow for user feedback #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This includes a initial working version of the feedback UX
@cbjuan @vabarbosa This is just an initial draft, but outside of fixing the dialog UI it's fully featured and complete. If you could take a look, I included a detailed description and called out specific questions I'd like answers to. |
After a worrying thought entered my head I tested how far the scope go on this and confirmed it is limited to a specific user instance of jupyterlab and not a server instance. Ie the scope is shared across every open notebook, but not between the same jupyterlab instance opened in another browser tab. Relatedly it does not persist on page reload. |
I have just pushed the final updates and updated the top description with new screen shots, descriptions, and limitations |
@cbjuan I just pushed the update to include the input/output values as now allowed by the service https://qiskit-code-assistant.quantum.ibm.com/docs#/Feedback/submit_feedback_feedback_post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, so approving
I'd love to test it before publishing a new version with this. Also, could you take a look to this PR, @vabarbosa ?
@cbjuan so do you want to test this PR by building it locally or do you mean we should merge and release an rc for testing via pip install wheel file? |
I was thinking on testing it locally, but you're right, probably is cleaner to publish it as a rc and test it from there. Let's do it after @vabarbosa review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple minor comments, but nothing blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This adds a UI for users to provide feedback on the Qiskit Code Assistant as well as specific prompts.
Included features
Current Limitations
Open Questions