Skip to content

Update default timeout from 10s to 15s #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Conversation

ajbozarth
Copy link
Collaborator

Description

Alternate approach to #23 that only increases the timeout values and docs and don't add any extra config functionality

Linked Issue(s)

Fixes #22

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@cbjuan cbjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cbjuan
Copy link
Member

cbjuan commented Jun 26, 2025

I closed #23 as I agree with you it's not the proper way to do it as of now. Let's test this and see if we still need something such as in the previous one. Thanks again

@cbjuan cbjuan merged commit 53a137b into Qiskit:main Jun 26, 2025
7 of 8 checks passed
@ajbozarth ajbozarth deleted the timeout branch June 26, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase timeouts for generation
2 participants