[WIP] Add UnitarySynthesis transpiler pass to C API #14740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the UnitarySynthesis transpiler pass's rust internals to add a path for running the pass without Python. This is a requirement for using the pass from the C API. The complexity is that part of the pass's core functionality is still in Python, mainly two decomposers the XXDecomposer and the QSD function. These code paths are super commonly used, although the QSD function will be necessary to decompose 3+ qubit unitaries this is an ok limitation for the initial C API especially since development of a rust QSD is in progress this is only a temporary limitation. The path through the pass without Python removes the explicit py token from the main entrypoint and also adds a new rust entrypoint distinct from the Python caller that has a new argument run_python_decomposers. If this argument is set to `false` and either the xx decomposer or qsd path are triggered the function will now either skip it or return an error if there is no alternative. Part of Qiskit#14451
This commit adds a standalone transpiler pass function to the C API for running the UnitarySynthesis transpiler pass. This pass mutates a dag in place and updates the provided circuit pointer with the newly generated circuit. Right now the pass doesn't support >= 3q unitaries, targets that would rely on the XX decomposer, or have the unitary synthesis plugin interface that exists in Python. The first two could be fixed if/when those synthesis algorithms are ported to C, but the plugin interface will need some thought to think about how to expose that via the C FFI, it will certainly be different/distinct from the Python interface but some discovery and design will be needed to come up with a reasonable interface to make unitary synthesis pluggable from C. Fixes Qiskit#14451
mtreinish
added
on hold
|
One or more of the following people are relevant to this code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a standalone transpiler pass function to the C API for
running the UnitarySynthesis transpiler pass. This pass mutates a dag
in place and updates the provided circuit pointer with the newly
generated circuit. Right now the pass doesn't support >= 3q unitaries,
targets that would rely on the XX decomposer, or have the unitary
synthesis plugin interface that exists in Python. The first two could be
fixed if/when those synthesis algorithms are ported to C, but the plugin
interface will need some thought to think about how to expose that via
the C FFI, it will certainly be different/distinct from the Python
interface but some discovery and design will be needed to come up with a
reasonable interface to make unitary synthesis pluggable from C.
Details and comments
Fixes #14451
This depends on #14732 and will need to be rebased after that PR merges. In the meantime you can look at the HEAD commit to see the contents of this PR: 2524561
TODO: