-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[WIP] C API: Burn ConsolidateBlocks
#14751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ConsolidateBlocks
ConsolidateBlocks
ConsolidateBlocks
ConsolidateBlocks
Pull Request Test Coverage Report for Build 16524455693Details
💛 - Coveralls |
|
||
/// Helper function that extracts the decomposer and basis gate directly from the [Target]. | ||
#[inline] | ||
fn get_decomposer_and_basis_gate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be integrated into the internal rust API. We will need a rust entrypoint that has the signature of the C API to call from the transpile()
function. The C API should be doing appreciable logic like this it should just mirror the request to the rust api and handle basic type conversion from the limitations of the FFI boundary to something more rust native.
41f7c26
to
3fa83b9
Compare
Built on top of Qiskit#14748. The following commit adds the ability for the `ConsolidateBlocks` pass to instantiate decomposers and choose a basis gate based on the provided `Target`. In the case that a `Target` is not provided, it will default to a `TwoBasisDecomposer` with a `CX` gate.
- Add `qk_transpiler_pass_standalone_consolidate_blocks` to expose a version of the `ConsolidateBlocks` pass to C. The pass runs on an instance of `CircuitData` and an optional `Target`.
f526557
to
2e079bc
Compare
Summary
Add
qk_transpiler_pass_standalone_consolidate_blocks
to expose a version of theConsolidateBlocks
pass to C. The pass runs on an instance ofCircuitData
and an optionalTarget
.Pre-requisites:
ConsolidateBlocks
#14748ConsolidateBlocks
#14776Details and comments
Built on top of #14748 needs to be rebased after it merges.
Closes #14447