-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ODE compatibility issues for now #607
Conversation
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 71.21% 75.05% +3.83%
==========================================
Files 53 80 +27
Lines 3148 4346 +1198
==========================================
+ Hits 2242 3262 +1020
- Misses 906 1084 +178 see 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is still an issue related to __init
in BloqadeKrylov tests. Maybe we need to lower the version more?
did BlockadeKrylov fail because its test environment still uses BloqadeODE from the registry ? |
BloqadeExpr exports
the environment i used for running the test ...
|
The problem is that one of the tests depends on BloqadeODE which is currently broken by the compatibility. Its a test dependency so that "dev"ing the local package doesn't cover that dependency so I think we need to just merge this first and release a new version of BloqadeODE before we can fix the CI. |
in 1.9 the latest version of OrdinaryDiffEq seems to have compatibility issues with our custom
__init
function. I've set the compatibility to the last compatible version which seems to be anything before 6.58.0.