Forward defs from qasm2.inline to python Lowering.
#151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Roger-luo
reviewed
Apr 15, 2025
src/bloqade/qasm2/parse/lowering.py
Outdated
| @@ -27,6 +27,7 @@ def run( | |||
| lineno_offset: int = 0, | |||
| col_offset: int = 0, | |||
| compactify: bool = True, | |||
| return_defs: bool = False, | |||
There was a problem hiding this comment.
this is breaking the interface too. pyright would have errored here for you locally
weinbe58
force-pushed
the
phil/fix-linline-qasm2-defs
branch
from
2e9b46d to
0253a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to close #150 I added a flag that allows you to obtrain the
defsfrom the last frame used in qasm2 lowering. The idea is those defs need to be given to the python lowering frame to make sure those names are availible to continue lowering the rest of the python code. This is OK because all declarations in qasm2 are global.