-
Notifications
You must be signed in to change notification settings - Fork 1
load
+ loadfile
methods for QASM2
lowering.
#159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/bloqade/qasm2/parse/lowering.py:110
- [nitpick] The parameter 'file' in loadfile shadows a built-in. Consider renaming it to 'file_path' for clarity.
if isinstance(file, str):
src/bloqade/qasm2/parse/lowering.py:111
- [nitpick] Instead of using os.path.split followed by pathlib.Path, consider using pathlib.Path(file) directly for improved clarity and reliability.
if isinstance(file, str): file = pathlib.Path(*os.path.split(file))
source: str, | ||
kernel_name: str, | ||
*, | ||
returns: str | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add multiple returns later, but you can't do this for a standard qasm2 file because we do not support tuples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think this is ok.
addresses #150