Skip to content

Measure Refactor. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 29, 2025
Merged

Measure Refactor. #213

merged 7 commits into from
Apr 29, 2025

Conversation

weinbe58
Copy link
Member

This PR addresses #158

@weinbe58 weinbe58 marked this pull request as draft April 28, 2025 15:23
@weinbe58 weinbe58 marked this pull request as ready for review April 29, 2025 15:48
@weinbe58 weinbe58 requested a review from johnzl-777 April 29, 2025 15:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6270 5388 86% 0% 🟢

New Files

File Coverage Status
src/bloqade/squin/rewrite/_init_.py 100% 🟢
src/bloqade/squin/rewrite/measure_desugar.py 93% 🟢
TOTAL 97% 🟢

Modified Files

File Coverage Status
src/bloqade/squin/groups.py 97% 🟢
src/bloqade/squin/qubit.py 92% 🟢
TOTAL 94% 🟢

updated for commit: 8714998 by action🐍

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/squin/rewrite/measure_desugar.py 93.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

johnzl-777
johnzl-777 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@johnzl-777 johnzl-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion about naming, otherwise everything looks good 👍

@weinbe58 weinbe58 merged commit f039789 into main Apr 29, 2025
11 checks passed
@weinbe58 weinbe58 deleted the phil/measure-refactor branch April 29, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnzl-777 johnzl-777 johnzl-777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weinbe58 @johnzl-777