Add Broadcast to wire dialect #217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnzl-777
changed the title
weinbe58
requested changes
Apr 30, 2025
Merged
weinbe58
pushed a commit
that referenced
this pull request
May 1, 2025
This adds `broadcast` from the qubit dialect into the `wire` dialect as well for squin. I added unit tests specifically for constprop as well and took @weinbe58 's feedback to add things into the constprop impl. I'll be very honest, I just carried over my work from #217 because I think I did some improper merge and it broke something somewhere else 😅 and the CI failing but my local run working was annoying me too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weinbe58 and I are in agreement that the work on #209 should be mirrored (that is, the statement
Broadcastthat exists in the qubit dialect) should be present in the wire dialect as well.It occurred to me during the development thatPhillip pointed out this not worth it for just two similar classes and I find myself in agreementApplyandBroadcastin BOTH dialects have identical structure and that it might be worth introducing a parent class to them to keep things DRY so I've gone ahead and done that.I don't know if this is related (I can try to create an MWE and file a bug report) but the pretty printing that used to work (even before I made modifications to the statements in the dialects) now seems to fail to find the default pretty print
implin statement. It just goes straight to saying theABCMetadoesn't have it implemented which is a bit odd to me.