Implement scf & invoke methods for fidelity analysis #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The for loop test is failing because of a bug in the address analysis, or really kirin, see QuEraComputing/kirin#408. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #267 in order for tests to pass.
Also, I'm doing quite some hacky stuff right now:
@weinbe58 When invoking a nested kernel via
run_method, I have to re-run the address analysis in order to be able to access the qubit addresses from theaddr_framewhen running the analysis for the nested method. Afterwards, I have to reset. That's super ugly and feels like a hack. Do you know a better way to do this?Similarly, the
post_succ_hookis also run when callingrun_method. Since I'm updating stuff in-place there, I want to avoid that. I've achieved that via a similar hack setting a boolean flag.