Support cirq classical control when lowering a circuit to squin #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-pl
commented
Jun 12, 2025
Comment on lines
+176
to
+197
| # NOTE: there is currently no convenient ilist.any method, so we need to use foldl | ||
| # with a simple function that just does an or | ||
|
|
||
| def bool_op_or(x: bool, y: bool) -> bool: | ||
| return x or y | ||
|
|
||
| f_code = state.current_frame.push( | ||
| lowering.Python(self.dialects).python_function(bool_op_or) | ||
| ) | ||
| fn = ir.Method( | ||
| mod=None, | ||
| py_func=bool_op_or, | ||
| sym_name="bool_op_or", | ||
| arg_names=[], | ||
| dialects=self.dialects, | ||
| code=f_code, | ||
| ) | ||
| f_const = state.current_frame.push(py.constant.Constant(fn)) | ||
| init_val = state.current_frame.push(py.Constant(False)).result | ||
| condition = state.current_frame.push( | ||
| ilist.Foldl(f_const.result, measurement_outcome, init=init_val) | ||
| ).result |
There was a problem hiding this comment.
@Roger-luo Please take a look at this part here specifically. I'm not sure if I'm adding the function here correctly.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to support classical control with measurements on multiple qubits resulting in an ilist.