Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacked Prefect functions to upstream Prefect #2473

Open
Andrew-S-Rosen opened this issue Sep 19, 2024 · 0 comments
Open

Remove hacked Prefect functions to upstream Prefect #2473

Andrew-S-Rosen opened this issue Sep 19, 2024 · 0 comments

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Sep 19, 2024

What would you like to report?

In #2460 and #2462 by @zulissimeta, we have added some routines to nicely resolve Prefect futures. However, this involved some copying of boilerplate code that should really be submitted to the upstream Prefect library. While somewhat annoying, this should be taken care of ASAP to prevent breakages.

Here are the functions to take care of: https://github.com/Quantum-Accelerators/quacc/blob/main/src/quacc/wflow_tools/prefect_utils.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant