-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small bugfix for async prefect functions #2462
Small bugfix for async prefect functions #2462
Conversation
Can one of the admins verify this patch? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2462 +/- ##
==========================================
- Coverage 98.38% 97.41% -0.98%
==========================================
Files 85 85
Lines 3478 3518 +40
==========================================
+ Hits 3422 3427 +5
- Misses 56 91 +35 ☔ View full report in Codecov by Sentry. |
@zulissimeta: Thank you! I have never used async flows. Before merging, two questions:
|
@Andrew-S-Rosen Good suggestion! Updated with some tests, and caught another bug. |
…mpleted, add a quacc setting
@zulissimeta: Thank you again for this PR! I am mostly going to take this on faith since I'm not too familiar with the async work. However, it would be really helpful if we could increase the coverage on this PR. Would this be possible? Retaining the high code coverage of the repo is extremely helpful for me in maintaining this package. |
…to prefect_async_patch
Thank you, @zulissimeta! Merging but opening an issue to record the need to move things upstream: #2473 |
c39345b
into
Quantum-Accelerators:main
Summary of Changes
This provides a small bug fix for the recent patch to how prefect flows are handled. The prior methods only worked for sync flows.
Requirements
main
).Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.