Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

[WIP] Fix 170 - an improved patch #173

Merged
merged 6 commits into from
Nov 16, 2021
Merged

[WIP] Fix 170 - an improved patch #173

merged 6 commits into from
Nov 16, 2021

Conversation

GiggleLiu
Copy link
Member

This is fix the issue in comment: #170 (comment)

But there are still some bugs related to Zygote.

e.g.

julia> Zygote.gradient(x->x.content.theta, Daggered(Rx(0.5)))
(nothing,)

I do not know why this gradient is so hard for Zygote. @Roger-luo

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #173 (438d4dc) into master (f3fede2) will decrease coverage by 0.03%.
The diff coverage is 82.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   81.13%   81.09%   -0.04%     
==========================================
  Files          46       46              
  Lines        2136     2185      +49     
==========================================
+ Hits         1733     1772      +39     
- Misses        403      413      +10     
Impacted Files Coverage Δ
src/autodiff/chainrules_patch.jl 87.50% <82.14%> (-8.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fede2...438d4dc. Read the comment docs.

@Roger-luo Roger-luo merged commit 0c9e1e5 into master Nov 16, 2021
@Roger-luo Roger-luo deleted the fix-170 branch November 16, 2021 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants