Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc + Structural Improvement #103

Merged
merged 11 commits into from
Oct 20, 2023
Merged

Doc + Structural Improvement #103

merged 11 commits into from
Oct 20, 2023

Conversation

exAClior
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Application/Application.jl 100.00% <100.00%> (ø)
src/Application/to_eincode.jl 98.85% <100.00%> (ø)
src/PMG/PMG.jl 100.00% <100.00%> (ø)
src/PMG/planar_multigraph.jl 78.60% <ø> (ø)
src/Utils/Utils.jl 100.00% <100.00%> (ø)
src/Utils/phase.jl 74.24% <ø> (ø)
src/Utils/scalar.jl 100.00% <ø> (ø)
src/ZW/ZW.jl 100.00% <100.00%> (ø)
src/ZW/zw_adt.jl 75.00% <ø> (ø)
src/ZW/zw_diagram.jl 96.51% <ø> (ø)
... and 18 more

📢 Thoughts on this report? Let us know!.

@exAClior exAClior marked this pull request as ready for review October 19, 2023 03:41
Copy link
Member

@ChenZhao44 ChenZhao44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other parts look great. We only need some minor changes in the test files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping a test file that can run independently will be better. Some of the test files require modules, such as Test and ZXCalculus.ZX that are loaded from other files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for reviewing! I just finished added require modules.

@ChenZhao44 ChenZhao44 merged commit ec0d611 into master Oct 20, 2023
17 checks passed
@ChenZhao44 ChenZhao44 deleted the ys/docs-renaming branch October 20, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants