-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZXW rewrite rules + Differentiation #93
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 82.88% 82.46% -0.43%
==========================================
Files 16 17 +1
Lines 2478 2902 +424
==========================================
+ Hits 2054 2393 +339
- Misses 424 509 +85
☔ View full report in Codecov by Sentry. |
Hello @ChenZhao44 , could you please take a look at my differentiation implementation while I continue to work on the integration part? I did minimal testing just in case I need to rewrite the entire thing. |
@ChenZhao44 Hi! I fixed and tested everything including differentiation, integration of two sites and four sites, variance calculation. Everything passed! Could you please take a look at it at your convenience? Thanks! There are a few caveats for future user and future me. |
Need to fix #97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now!
No description provided.