Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Planar Multigraph with HalfEdge Data Structure #98

Merged
merged 51 commits into from
Sep 12, 2023
Merged

Implement Planar Multigraph with HalfEdge Data Structure #98

merged 51 commits into from
Sep 12, 2023

Conversation

exAClior
Copy link
Collaborator

@exAClior exAClior commented Sep 5, 2023

No description provided.

@exAClior
Copy link
Collaborator Author

exAClior commented Sep 5, 2023

We follow the API from this library

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage is 83.28% of modified lines.

❗ Current head aec35dd differs from pull request most recent head d0e4784. Consider uploading reports for the commit d0e4784 to get more accurate results

Files Changed Coverage
src/adts.jl 0.00%
src/parameter.jl ø
src/zxw_diagram.jl ø
src/planar_multigraph.jl 84.73%
src/ZXCalculus.jl 100.00%

📢 Thoughts on this report? Let us know!.

@exAClior exAClior changed the title [WIP] Implement Planar Multigraph with HalfEdge Data Structure Implement Planar Multigraph with HalfEdge Data Structure Sep 10, 2023
ChenZhao44
ChenZhao44 reviewed Sep 10, 2023
View reviewed changes
Copy link
Member

@ChenZhao44 ChenZhao44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in general. We can merge it once the tests of ZXW are fixed.

src/ZXCalculus.jl Outdated Show resolved Hide resolved
src/zw_diagram.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
src/planar_multigraph.jl Show resolved Hide resolved
test/planar_multigraph.jl Show resolved Hide resolved
@ChenZhao44 ChenZhao44 merged commit 389f4bf into master Sep 12, 2023
15 checks passed
@ChenZhao44 ChenZhao44 deleted the ys/planar-graph branch September 12, 2023 14:44
@contra-bit contra-bit mentioned this pull request Sep 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenZhao44 ChenZhao44 ChenZhao44 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exAClior @ChenZhao44