Fix plymouth on multi-screens with different resolution#41
Fix plymouth on multi-screens with different resolution#41alimirjamali wants to merge 1 commit intoQubesOS:mainfrom
Conversation
fixes: https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/205 Follow-up to this discussion: QubesOS#40 (comment)
|
@marmarek I do not have a PiKVM to test the above fix on it. It fixes the issue on my own setup but the external display has higher resolution than the internal in my setup. |
| logo.opacity_angle = 0; | ||
|
|
||
| fun refresh_callback () { | ||
| # Reposition everything 50 times per second |
There was a problem hiding this comment.
This looks scary ;) But if it helps, I'm happy :)
There was a problem hiding this comment.
This looks scary ;) But if it helps, I'm happy :)
I am not 100% sure if it fixes it. Actually the logo is repositioned every 50 seconds at the moment with the existing code before this fix. I am guessing that the plymouth render interleaves the default 50 refresh cycles between the two monitors. But I might be wrong.
There was a problem hiding this comment.
So it was a failure:
There was a problem hiding this comment.
Not yet, this step doesn't have the update installed yet.
There was a problem hiding this comment.
This one is with the update applied: https://openqa.qubes-os.org/tests/106932#step/startup/4
So, not looking good. When the current run completes, I'll double check if initramfs actually include your change.
There was a problem hiding this comment.
I have checked and your change is included there, and didn't help :(
There was a problem hiding this comment.
In the plymouth issue I included a debug log, but also info in which plymouth version it worked before. Maybe that will help...
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024082316-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests120 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable testsDetails
|
|
It's even funnier in plymouth from F41: https://openqa.qubes-os.org/tests/109762#step/firstboot/2, https://openqa.qubes-os.org/tests/109764#step/firstboot/14 but maybe a bit better? |
It makes very sense. The patch I submitted only recenters the dialog and the white box. Not the logo. I will add the logo shortly. Hopefully tonight. |
|
Note the linked screenshots do not use this PR |
|
The problem with my local tests is that the HDMI capture dongle which I use as the external monitor emulates a Full-HD monitor which has higher resolution than the laptop itself. So it is very hard to reproduce the bug. I have not found a way to force lower resolution on it. Are you using PyKVM as the external monitor? |
In this case yes, but I can reproduce the issue also with a FullHD monitor, while the internal panel is 4K (or 3K? some high resolution). Maybe there is some kernel/plymouth cmdline option to force specific resolution? |
|
And then, after pressing esc twice, the password entry migrates to the side, below the logo... |
|
The problem was elsewhere: #44 |
3 participants
fixes: https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/205
Follow-up to this discussion:
#40 (comment)