Improve device category description by marmarta · Pull Request #362 · QubesOS/qubes-core-admin-client

marmarta · 2025-06-05T14:47:44Z

Make it nicer, accept that some scanners might be misrepresented as camera, avoid underscore in the human-readable description.

codecov · 2025-06-05T15:07:59Z

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.12%. Comparing base (019c8aa) to head (5902314).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
qubesadmin/device_protocol.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   76.13%   76.12%   -0.01%     
==========================================
  Files          53       53              
  Lines        9202     9204       +2     
==========================================
+ Hits         7006     7007       +1     
- Misses       2196     2197       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2025-06-05T22:00:15Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071903-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

system_tests_pvgrub_salt_storage
- TC_42_PVHGrub_debian-12-xfce: test_010_template_based_vm (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
system_tests_dispvm
- TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
- TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
system_tests_devices
- TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
  AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...
system_tests_audio@hw1
- TC_20_AudioVM_PipeWire_fedora-42-xfce: test_226_audio_playback_pipewire (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
system_tests_qwt_win10_seamless@hw13
- windows_install: Failed (test died)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_qwt_win11@hw13
- windows_install: Failed (test died)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

10 failures

system_tests_pvgrub_salt_storage
- TC_42_PVHGrub_debian-12-xfce: test_010_template_based_vm (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_dispvm
- TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
- TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
system_tests_devices
- TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
  AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_audio@hw1
- TC_20_AudioVM_PipeWire_fedora-42-xfce: test_226_audio_playback_pipewire (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
system_tests_qwt_win10_seamless@hw13
- windows_install: Failed (test died)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_qwt_win11@hw13
- windows_install: Failed (test died)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

system_tests_extra
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.95233560090703...
system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_guivm_vnc_gui_interactive
- simple_gui_apps: unnamed test (unknown)
- simple_gui_apps: Failed (test died)
  # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

Unstable tests

Details

Performance Tests

Performance degradation:

9 performance degradations

debian-12-xfce_exec-data-simplex: 72.42 🔺 ( previous job: 65.51, degradation: 110.54%)
debian-12-xfce_exec-data-duplex-root: 82.28 🔺 ( previous job: 70.01, degradation: 117.53%)
whonix-gateway-17_exec-root: 43.81 🔺 ( previous job: 39.57, degradation: 110.71%)
whonix-gateway-17_socket: 9.83 🔺 ( previous job: 7.85, degradation: 125.16%)
whonix-gateway-17_socket-root: 8.70 🔺 ( previous job: 7.89, degradation: 110.24%)
whonix-gateway-17_exec-data-duplex-root: 101.47 🔺 ( previous job: 90.74, degradation: 111.83%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 253646.00 :small_red_triangle: ( previous job: 289982.00, degradation: 87.47%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 14119.00 :small_red_triangle: ( previous job: 17102.00, degradation: 82.56%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 105280.00 :small_red_triangle: ( previous job: 122848.00, degradation: 85.70%)

Remaining performance tests:

63 tests

debian-12-xfce_exec: 7.29 🟢 ( previous job: 8.63, improvement: 84.48%)
debian-12-xfce_exec-root: 29.21 🟢 ( previous job: 29.44, improvement: 99.24%)
debian-12-xfce_socket: 8.96 🔺 ( previous job: 8.50, degradation: 105.43%)
debian-12-xfce_socket-root: 8.56 🔺 ( previous job: 8.31, degradation: 102.94%)
debian-12-xfce_exec-data-duplex: 67.72 🟢 ( previous job: 73.55, improvement: 92.08%)
debian-12-xfce_socket-data-duplex: 160.98 🟢 ( previous job: 161.35, improvement: 99.77%)
fedora-42-xfce_exec: 9.10
fedora-42-xfce_exec-root: 58.04
fedora-42-xfce_socket: 8.05
fedora-42-xfce_socket-root: 8.53
fedora-42-xfce_exec-data-simplex: 69.44
fedora-42-xfce_exec-data-duplex: 71.77
fedora-42-xfce_exec-data-duplex-root: 98.53
fedora-42-xfce_socket-data-duplex: 156.15
whonix-gateway-17_exec: 6.91 🟢 ( previous job: 7.34, improvement: 94.14%)
whonix-gateway-17_exec-data-simplex: 78.89 🔺 ( previous job: 77.76, degradation: 101.45%)
whonix-gateway-17_exec-data-duplex: 82.13 🔺 ( previous job: 78.39, degradation: 104.78%)
whonix-gateway-17_socket-data-duplex: 169.74 🔺 ( previous job: 161.95, degradation: 104.81%)
whonix-workstation-17_exec: 7.73 🟢 ( previous job: 8.27, improvement: 93.38%)
whonix-workstation-17_exec-root: 58.83 🔺 ( previous job: 57.61, degradation: 102.11%)
whonix-workstation-17_socket: 8.78 🟢 ( previous job: 8.97, improvement: 97.90%)
whonix-workstation-17_socket-root: 10.34 🔺 ( previous job: 9.46, degradation: 109.33%)
whonix-workstation-17_exec-data-simplex: 62.25 🟢 ( previous job: 74.54, improvement: 83.51%)
whonix-workstation-17_exec-data-duplex: 81.62 🔺 ( previous job: 74.84, degradation: 109.07%)
whonix-workstation-17_exec-data-duplex-root: 86.93 🔺 ( previous job: 86.00, degradation: 101.08%)
whonix-workstation-17_socket-data-duplex: 169.35 🔺 ( previous job: 160.20, degradation: 105.71%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 135279.00 :green_circle: ( previous job: 101988.00, improvement: 132.64%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 56932.00 :green_circle: ( previous job: 14284.00, improvement: 398.57%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 38763.00 :green_circle: ( previous job: 32696.00, improvement: 118.56%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1354.00 :green_circle: ( previous job: 1091.00, improvement: 124.11%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11835.00 :green_circle: ( previous job: 11086.00, improvement: 106.76%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4559.00 :green_circle: ( previous job: 1840.00, improvement: 247.77%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 500991.00 :green_circle: ( previous job: 289182.00, improvement: 173.24%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 439286.00 :green_circle: ( previous job: 433654.00, improvement: 101.30%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 157711.00 :small_red_triangle: ( previous job: 167872.00, degradation: 93.95%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103257.00 :small_red_triangle: ( previous job: 108760.00, degradation: 94.94%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 9261.00 :green_circle: ( previous job: 8874.00, improvement: 104.36%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7920.00 :green_circle: ( previous job: 6356.00, improvement: 124.61%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4954.00 :green_circle: ( previous job: 4420.00, improvement: 112.08%)
fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 387786.00
fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 274280.00
fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 308223.00
fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 139265.00
fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 83540.00
fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5449.00
fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8108.00
fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 2626.00
fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 334154.00
fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 225791.00
fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 281044.00
fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 125146.00
fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 36961.00
fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2612.00
fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8504.00
fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1051.00
fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 346293.00
fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 208754.00
fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 292489.00
fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 106325.00
fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 46029.00
fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2084.00
fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8014.00
fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1975.00

Make it nicer, accept that some scanners might be misrepresented as camera, avoid underscore in the human-readable description.

marmarek added openqa-pending and removed openqa-pending labels Jun 5, 2025

This was referenced Jun 5, 2025

merge_tops : throw better error if top is invalid QubesOS/qubes-mgmt-salt-base-topd#15

Draft

Device API changes QubesOS/qubes-desktop-linux-manager#258

Merged

Improve device category description

e3cd011

Make it nicer, accept that some scanners might be misrepresented as camera, avoid underscore in the human-readable description.

marmarta changed the title ~~Improve device category description~~ WIP: Improve device category description Jun 6, 2025

marmarta marked this pull request as draft June 6, 2025 12:50

Fix incorrect parent device serialization

5902314

marmarta force-pushed the more_dev_api_updt branch from 0c847ec to 5902314 Compare June 24, 2025 18:34

marmarta changed the title ~~WIP: Improve device category description~~ Improve device category description Jun 24, 2025

marmarta marked this pull request as ready for review June 24, 2025 18:37

marmarta mentioned this pull request Jun 25, 2025

Use new API in the Devices Widget QubesOS/qubes-desktop-linux-manager#267

Merged

marmarek added the openqa-pending label Jun 26, 2025

qubesos-bot mentioned this pull request Jun 27, 2025

Don't try to send grants for not realized windows QubesOS/qubes-gui-agent-linux#236

Merged

marmarek approved these changes Jul 20, 2025

View reviewed changes

marmarek merged commit a38508c into QubesOS:main Jul 20, 2025
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve device category description#362

Improve device category description#362
marmarek merged 2 commits intoQubesOS:mainfrom
marmarta:more_dev_api_updt

marmarta commented Jun 5, 2025

Uh oh!

codecov bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

marmarta commented Jun 5, 2025

Uh oh!

codecov bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jun 5, 2025 •

edited

Loading

qubesos-bot commented Jun 5, 2025 •

edited

Loading