Update service dependencies for modular libvirt daemon part 2 #628
Conversation
libvirtd.service is the monolithic one, virtxend and virtnodedevd are modular one. Add related After= dependencies to qubesd.service. This is especially necessary on shutdown, to allow shutting down VMs work before libvirt is stopped. Add also remote-fs.target there, to cover all filesystem related units running already too. QubesOS/qubes-issues#9402
marmarek
force-pushed
the
service-deps
branch
from
f7cf78d to
9b58e01
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 69.32% 69.32%
=======================================
Files 58 58
Lines 11993 11993
=======================================
Hits 8314 8314
Misses 3679 3679
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024102822-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests29 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable tests
|
2 participants
libvirtd.service is the monolithic one, virtxend and virtnodedevd are
modular one. Add related After= dependencies to qubesd.service. This is
especially necessary on shutdown, to allow shutting down VMs work before
libvirt is stopped.
QubesOS/qubes-issues#9402