Skip to content

Conversation

ben-grande
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (929dce2) to head (2928e74).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/qubesvm.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   70.83%   70.79%   -0.05%     
==========================================
  Files          61       61              
  Lines       13463    13475      +12     
==========================================
+ Hits         9537     9539       +2     
- Misses       3926     3936      +10     
Flag Coverage Δ
unittests 70.79% <26.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-grande ben-grande force-pushed the preload-early-destroy branch from 3d80ec9 to 2928e74 Compare July 7, 2025 17:28
@ben-grande
Copy link
Contributor Author

Last talk I had with Marek, he was worried that hiding the exception might prevent some cleanup. From past tests, I remember it cleaning the volume, but I didn't check if it missing something. To revise.

@ben-grande
Copy link
Contributor Author

PipelineRetryFailed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant