Add global preload to template gathering #718
Conversation
ben-grande
force-pushed
the
preload-suspend
branch
from
b0102b3 to
a932795
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 70.55% 70.51% -0.05%
==========================================
Files 61 61
Lines 13616 13623 +7
==========================================
- Hits 9607 9606 -1
- Misses 4009 4017 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025082915-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 72 fixed
Unstable testsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:159 tests
|
ben-grande
force-pushed
the
preload-suspend
branch
from
762d58b to
2249d38
Compare
qubes/api/internal.py
Outdated
| def on_domain_delete( | ||
| cls, | ||
| subject, | ||
| event, | ||
| vm, | ||
| ): |
There was a problem hiding this comment.
Most (all?) of those reformatting looks bogus (black bug? wrong arguments?) - the line was way under 80 chars, so there is no need for splitting. And black doesn't attempt to do it for me...
There was a problem hiding this comment.
Strange indeed. Which black version do you have?
Fedora 42 black from repos:
% git rev-parse HEAD
2249d3871bef5494969c192f44afd7217be4a976
% black --version
black, 24.4.2 (compiled: no)
Python (CPython) 3.13.7
% black -l80 --check qubes/api/internal.py
All done! ✨ 🍰 ✨
1 file would be left unchanged.
Debian with black installed via pip (latest)
% git rev-parse HEAD
2249d3871bef5494969c192f44afd7217be4a976
% black --version
black, 25.1.0 (compiled: yes)
Python (CPython) 3.11.2
% black -l80 qubes/api/internal.py
All done! ✨ 🍰 ✨
1 file left unchanged.
There was a problem hiding this comment.
It passed CI with black 24.4.2 on https://gitlab.com/QubesOS/qubes-core-admin/-/jobs/11051605265.
It is a bogus change indeed..., I will amend the commit with only the relevant chunks of code from qubes/api/internal.py and see what the black from CI throws.
There was a problem hiding this comment.
New test didn't fail: https://gitlab.com/QubesOS/qubes-core-admin/-/jobs/11136244926
There was a problem hiding this comment.
And last test: https://gitlab.com/QubesOS/qubes-core-admin/-/jobs/11136313453
Why black wanted a reformatted version before I still don't know.
ben-grande
force-pushed
the
preload-suspend
branch
2 times, most recently
from
9feb281 to
996ca05
Compare
ben-grande
force-pushed
the
preload-suspend
branch
from
996ca05 to
dd43ddd
Compare
|
The openqa timeout is likely due to the global dispvm being set by anaconda. When calling |
The script communicates with qubesd, which during tests is the patched one (real one is stopped for the duration of tests) - so, I don't think this is the problem. Maybe the script is called before some features are set/cleared? |
ben-grande
force-pushed
the
preload-suspend
branch
2 times, most recently
from
188d0d1 to
ac42b4d
Compare
ben-grande
force-pushed
the
preload-suspend
branch
from
ac42b4d to
b4431ff
Compare
Affects suspend, which uses this function. For: QubesOS/qubes-issues#1512
- Easier copy-paste when code duplication is necessary; - Only fires event if the qube should be really preloaded, which is more difficult to do considering the global feature. The prior behavior didn't error out, just a warning log; - Add tests For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-suspend
branch
from
b4431ff to
10b3de5
Compare
Right... I needed to clear features of qubes outside of the test. |
This recently started failing. Last test run on current-testing (no PRs) is green: https://openqa.qubes-os.org/tests/150611, so it's most likely some of the included PRs to blame (not sure which one). |
|
Technically it could be also due to some commits merged into main, but not released yet. Given some are about backups, it's likely. |
https://openqa.qubes-os.org/tests/150359#step/system_tests/33 |
|
Yes, strange, I don't know how that happened. I remember seeing the results all green once, but the comment history does not show that... Anyway, #726 |
3 participants
Affects suspend, which uses this function.
For: QubesOS/qubes-issues#1512