-
-
Notifications
You must be signed in to change notification settings - Fork 116
Improve disposables docstrings #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Would be nice if there was an RTD build like for qubes-doc. |
Ignore pylint errors for now, but two other failed jobs are related to your changes. |
04be634
to
f883a47
Compare
9a778aa
to
1b138c2
Compare
PipelineRetry |
Not sure if you noticed, but it's here now :) |
Both pylint and mypy complain... |
1b138c2
to
3aebc76
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
+ Coverage 70.34% 70.36% +0.01%
==========================================
Files 61 61
Lines 13682 13687 +5
==========================================
+ Hits 9625 9631 +6
+ Misses 4057 4056 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3aebc76
to
d5ec7db
Compare
d5ec7db
to
6bd6093
Compare
For: QubesOS/qubes-doc#1554
For: QubesOS/qubes-issues#1512
When producing the disposable implementation docs](QubesOS/qubes-doc#1554 (comment)), docstrings were missing, so the links were not working.
I did this a bit fast, will do another pass soon.