Skip to content

Conversation

ben-grande
Copy link
Contributor

For: QubesOS/qubes-doc#1554
For: QubesOS/qubes-issues#1512


When producing the disposable implementation docs](QubesOS/qubes-doc#1554 (comment)), docstrings were missing, so the links were not working.

I did this a bit fast, will do another pass soon.

@ben-grande
Copy link
Contributor Author

Would be nice if there was an RTD build like for qubes-doc.

@marmarek
Copy link
Member

Ignore pylint errors for now, but two other failed jobs are related to your changes.

@ben-grande ben-grande force-pushed the preload-doc branch 2 times, most recently from 04be634 to f883a47 Compare October 15, 2025 14:34
@ben-grande ben-grande marked this pull request as ready for review October 15, 2025 14:40
@ben-grande ben-grande force-pushed the preload-doc branch 5 times, most recently from 9a778aa to 1b138c2 Compare October 15, 2025 15:00
@marmarek
Copy link
Member

PipelineRetry

@marmarek
Copy link
Member

Would be nice if there was an RTD build like for qubes-doc.

Not sure if you noticed, but it's here now :)

@marmarek
Copy link
Member

Both pylint and mypy complain...

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.36%. Comparing base (76b23c9) to head (6bd6093).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/dispvm.py 88.46% 3 Missing ⚠️
qubes/vm/mix/dvmtemplate.py 92.30% 1 Missing ⚠️
qubes/vm/qubesvm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   70.34%   70.36%   +0.01%     
==========================================
  Files          61       61              
  Lines       13682    13687       +5     
==========================================
+ Hits         9625     9631       +6     
+ Misses       4057     4056       -1     
Flag Coverage Δ
unittests 70.36% <87.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants