qfile-agent: fix CLI progress display unit mismatch#509
Merged
marmarek merged 2 commits intoQubesOS:mainfrom Jul 5, 2024
Merged
qfile-agent: fix CLI progress display unit mismatch#509marmarek merged 2 commits intoQubesOS:mainfrom
marmarek merged 2 commits intoQubesOS:mainfrom
Conversation
qubes-fs-tree-check outputs the total estimated size in bytes, not KB.
Fix the display bug by renaming the env variable that's used to pass
this number (in the qvm-copy wrapper script) to $FILECOPY_TOTAL_BYTES,
and then making qfile-agent convert from bytes to KB display units.
$ truncate -s 10K foo
$ qvm-copy foo # before:
sent 10/10240 KB
$ qvm-copy foo # after:
sent 10/10 KB
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 331 331
Misses 138 138 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 28, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070414-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 4 fixed
Unstable testsDetails
|
This was referenced Jun 28, 2024
Merged
marmarek
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message