-
-
Notifications
You must be signed in to change notification settings - Fork 125
Use socks5 proxy on Whonix Gateway to fix onion urls resolution #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 3 3
Lines 481 481
=======================================
Hits 342 342
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025102308-4.3-whonix&flavor=templates Test run included the following: New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests5 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 5 fixed
Unstable testsPerformance TestsPerformance degradation:No issues Remaining performance tests:No remaining performance tests |
a410ff2
to
dcd4ade
Compare
I know there was a discussion on Matrix about this, but after looking at the code and talking with Patrick, I'm slightly confused; Whonix-Gateway 18 has a curl wrapper that should set up the proxy properly already, so I would expect the bare |
Yes, I think curl options are not really necessary.
Yes, it uses libcurl. |
When sys-whonix is used as updatevm, with repositories set to onion addresses, DNF (or rather curl) refuse to resolve the addresses, even though it is talking to Tor. See curl/curl#11125 Fix this by setting socks proxy explicitly. Use socks5h:// protocol to really delegate hostname resolution to the server. Do the same in qvm-template-repo-query (qubes.TemplateSearch and qubes.TemplateDownload services), as they also use dnf. QubesOS/qubes-issues#10253
dcd4ade
to
2e68781
Compare
When sys-whonix is used as updatevm, with repositories set to onion
addresses, DNF (or rather curl) refuse to resolve the addresses, even
though it is talking to Tor. See
curl/curl#11125
Fix this by setting socks proxy explicitly. Use socks5h:// protocol to
really delegate hostname resolution to the server.
Do the same in qvm-template-repo-query (qubes.TemplateSearch and
qubes.TemplateDownload services), as they also use dnf and curl.
QubesOS/qubes-issues#10253