Missing dependencies in RPM spec #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 58 58
Lines 11140 11140
=======================================
Hits 10389 10389
Misses 751 751 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marmarta
approved these changes
Mar 17, 2025
marmarek
requested changes
Mar 19, 2025
| Requires: xhost | ||
| Requires: gtksourceview4 | ||
| Requires: gnome-icon-theme | ||
| Requires: xfce4-settings |
There was a problem hiding this comment.
This package shouldn't be necessary, after all you can use it under KDE. What breaks without it? The linked issue says it's icons, but at least in R4.3 we have new custom icons created for domains widget specifically, so they couldn't possibly be provided by xfce.
There was a problem hiding this comment.
I believe the original issue was related to i3. And depending on how far out R4.3 is, it may be a while until it's resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dependencies which were easily removed and could break icons and some UX features. Resolves QubesOS/qubes-issues/issues/9359