Give windows focus before sending events #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events from the GUI daemon are directed at specific windows. Ensuring that they are sent to the correct window is more importent than obeying the ICCCM input hint. Giving pointer focus to a window is accomplished by raising it. Fixes QubesOS/qubes-issues#3267.
|
The "ignore input hint" part sounds suspicious. Support for it was added for a reason. See this thread from 9 years ago and verify if it works in that case too. Furthermore, some toolkits (GTK?) handle input events through a dedicated off-screen window instead of a window you see, I guess calling |
|
What about merging QubesOS/qubes-gui-daemon#104? That has been reported to help. |
Some windows, such as override redirect windows, should never get input focus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events from the GUI daemon are directed at specific windows. Ensuring
that they are sent to the correct window is more importent than obeying
the ICCCM input hint. Giving pointer focus to a window is accomplished
by raising it.
Fixes QubesOS/qubes-issues#3267.