-
-
Notifications
You must be signed in to change notification settings - Fork 71
Skip updating disk size when qube is removed #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
- Coverage 69.17% 69.12% -0.06%
==========================================
Files 17 17
Lines 3913 3926 +13
==========================================
+ Hits 2707 2714 +7
- Misses 1206 1212 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025101005-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests17 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 83 fixed
Unstable testsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:166 tests
|
Fixes: QubesOS/qubes-issues#10285
For: QubesOS/qubes-issues#1512
I got to reproduce the issue:
When clicking/focusing on qube manager, it triggers QEvent.Type.WindowActivate which calls
VmManagerWindow.update_running_size()
.I logged
would fail
the line above the pass and got confirmation that it would fail there. I could not get it to fail in other places.