Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to extend
patch-0001-libxl-conditionally-allow-PCI-passthrough-on-PV-with.patch
in order to allow usingpci_get_pdev
whenpci_get_pdev_by_domain
was unsuccessful, as it seems that update broke something that incorrectly reports the owner of a device thus renderingpci_get_pdev_by_domain
useless (see QubesOS/qubes-issues#3217 (comment))I see the base patch already includes some utilities to make this work, but I would like to ask before proceed:
libxl__is_insecure_pv_passthrough_enabled
or redefine in this file?iommu_enabled
be stored globally so it's easier to get (as it will probably be used in more patches)type == LIBXL_DOMAIN_TYPE_PV
check redundant in this exact location?I'm not very knowledgeable in
C
but given some advise regarding these questions I can complete this PR. Also if you see that this PR should be another flag and not be used implicitly withqubes.enable_insecure_pv_passthrough
, please let me know.