-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joining fetch #521
Open
RichLogan
wants to merge
11
commits into
fetch-header
Choose a base branch
from
joining-fetch
base: fetch-header
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Joining fetch #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichLogan
commented
Mar 13, 2025
RichLogan
commented
Mar 13, 2025
RichLogan
commented
Mar 13, 2025
RichLogan
commented
Mar 13, 2025
I am sure there is some state cleanup missing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement joining fetch.
The idea here, (if others agree), if that joining fetches are so tied to subscriptions that the former is an extension of the latter in terms of the public facing API. When you create a
SubscribeTrackHandler
you can optionally do so with a joining fetch. Those objects will be returned to your subscribe track handler identically to how live objects would be for convenience. A fetch handler is used internally to make facilitate that mapping, although there are no guarantees about ordering or interleaving with the live stream.Fixes #362