Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining fetch #521

Open
wants to merge 11 commits into
base: fetch-header
Choose a base branch
from
Open

Joining fetch #521

wants to merge 11 commits into from

Conversation

RichLogan
Copy link
Contributor

@RichLogan RichLogan commented Mar 12, 2025

Implement joining fetch.

The idea here, (if others agree), if that joining fetches are so tied to subscriptions that the former is an extension of the latter in terms of the public facing API. When you create a SubscribeTrackHandler you can optionally do so with a joining fetch. Those objects will be returned to your subscribe track handler identically to how live objects would be for convenience. A fetch handler is used internally to make facilitate that mapping, although there are no guarantees about ordering or interleaving with the live stream.

./qserver # Server.
./qclient --pub_namespace=ns --pub_name=name --clock # Publisher
./qclient --sub_namespace=ns --sub_name=name # Regular Subscriber
./qclient --sub_namespace=ns --sub_name=name --joining_fetch # 2nd Subscribe using Joining Fetch (allow time for some objects to be published). 

Fixes #362

@RichLogan RichLogan changed the base branch from main to fetch-header March 14, 2025 14:46
@RichLogan RichLogan marked this pull request as ready for review March 17, 2025 10:24
@RichLogan
Copy link
Contributor Author

I am sure there is some state cleanup missing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant