Deliver fetch data on fetch stream #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichLogan
commented
Mar 14, 2025
(min(stream type) = 1) + (min(fetch_header) = 1) = 2
RichLogan
added
the
not ready
|
|
RichLogan
removed
the
not ready
RichLogan
changed the title
|
If this gets merged, a reminder to add an issue that group order fetch is not implemented. |
GhostofCookie
approved these changes
Mar 14, 2025
| @@ -42,7 +42,7 @@ namespace quicr { | |||
| /** | |||
| * Minimum bytes needed to write before considering to send. This doesn't | |||
There was a problem hiding this comment.
Not a part of this review, but the comment is incomplete.
There was a problem hiding this comment.
+1 it's actually confusing because this check is on receive.
src/transport_picoquic.h
Outdated
| @@ -42,7 +42,7 @@ namespace quicr { | |||
| /** | |||
| * Minimum bytes needed to write before considering to send. This doesn't | |||
| */ | |||
| constexpr int kMinStreamBytesForSend = 4; | |||
| constexpr int kMinStreamBytesForSend = 1; | |||
There was a problem hiding this comment.
Is this correct? I'm not sure why it was 4 before.
There was a problem hiding this comment.
I think it was 4 because that was the minimum size to read a stream subgroup header. However, now we could have a fetch header arrive, which is a single varint of data, plus the header type, which I think makes the new minimum 1+1=2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this sends fetch data on a single stream with
FETCH_HEADERfollowed by NFETCH_OBJECTs.The easiest way to do this seemed to be implement a new publish track handler derivative publish_fetch_handler, like how we have a fetch_handler that implements subscribe. This uses a different bind in the server (maybe it could be in transport) with a publish function that does the right thing.
This seems to work, but I'm reasonably new to this code so please help.
Also bear in mind that I'm trying to walk the line between not a hacky mess but in time for interop tomorrow 😂