-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deliver fetch data on fetch stream #527
base: main
Are you sure you want to change the base?
Conversation
(min(stream type) = 1) + (min(fetch_header) = 1) = 2
|
If this gets merged, a reminder to add an issue that group order fetch is not implemented. |
@@ -42,7 +42,7 @@ namespace quicr { | |||
/** | |||
* Minimum bytes needed to write before considering to send. This doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a part of this review, but the comment is incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 it's actually confusing because this check is on receive.
src/transport_picoquic.h
Outdated
@@ -42,7 +42,7 @@ namespace quicr { | |||
/** | |||
* Minimum bytes needed to write before considering to send. This doesn't | |||
*/ | |||
constexpr int kMinStreamBytesForSend = 4; | |||
constexpr int kMinStreamBytesForSend = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? I'm not sure why it was 4 before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was 4 because that was the minimum size to read a stream subgroup header. However, now we could have a fetch header arrive, which is a single varint of data, plus the header type, which I think makes the new minimum 1+1=2
.
I think this sends fetch data on a single stream with
FETCH_HEADER
followed by NFETCH_OBJECT
s.The easiest way to do this seemed to be implement a new publish track handler derivative publish_fetch_handler, like how we have a fetch_handler that implements subscribe. This uses a different bind in the server (maybe it could be in transport) with a publish function that does the right thing.
This seems to work, but I'm reasonably new to this code so please help.
Also bear in mind that I'm trying to walk the line between not a hacky mess but in time for interop tomorrow 😂