This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Bring the esp changes upto the latest transport (WIP) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TimEvens Love to get feedback on this PR. I will be testing this on esp platform in the meanwhile. |
TimEvens
approved these changes
Mar 4, 2024
| @@ -88,7 +88,7 @@ main() | |||
| { | |||
| char* envVar; | |||
|
|
|||
| TransportRemote server = TransportRemote{ "127.0.0.1", 1234, TransportProtocol::QUIC }; | |||
| TransportRemote server = TransportRemote{ "127.0.0.1", 1234, TransportProtocol::UDP }; | |||
There was a problem hiding this comment.
We should probably make this a config... although I don't think it's urgent because I believe most for testing will modify this code anyway.
| @@ -98,7 +98,7 @@ int main() { | |||
| cantina::LoggerPointer logger = std::make_shared<cantina::Logger>("ECHO"); | |||
| Delegate d(logger); | |||
| TransportRemote serverIp = | |||
| TransportRemote{"127.0.0.1", 1234, TransportProtocol::QUIC}; | |||
| TransportRemote{"127.0.0.1", 1234, TransportProtocol::UDP}; | |||
@TimEvens yes let's merge it .. I will bring in more changes in small quantum's that needs some more work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rework of PR #63 . This tries to bring the esp additions to match the latest UDP transport.
This PR seems to not break non esp code as confirmed by running echo server and client.
Look forward for some early feedback and would be nice to get this moving along in coming weeks,