Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config fallback timeout #620

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Conversation

aaa123eee
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Currently, fallback timeout is hardcoded with 9999. It would be nice to have it configurable

Use cases and why

    1. Developers desired to execute 3rd parties ASAP and don't want to wait 10s
    1. Developers want to run 3rd parties in worker as much as possible and can wait more

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:57pm

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aaa123eee your help and thoughts are really valuable 🚀
Now the project is community driven, it's under QwikDev org and we are planning first class support for this library. Any help is more than welcome

@gioboa gioboa merged commit 23c133d into QwikDev:main Nov 18, 2024
5 checks passed
@aaa123eee aaa123eee deleted the config-timeout branch November 18, 2024 12:19
@aaa123eee
Copy link
Contributor Author

Thanks @aaa123eee your help and thoughts are really valuable 🚀 Now the project is community driven, it's under QwikDev org and we are planning first class support for this library. Any help is more than welcome

That's amazing news, thank you! I am happy to help!

@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants